Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propagate incomplete query status via warning #420

Merged
merged 2 commits into from
Jun 3, 2022
Merged

Propagate incomplete query status via warning #420

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4dfb39f
propagate incomplete query status and warn
eddelbuettel Jun 2, 2022
07852d8
test for warning and status on incomplete query
eddelbuettel Jun 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DESCRIPTION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Package: tiledb
Type: Package
Version: 0.13.0.1
Version: 0.13.0.3
Title: Universal Storage Engine for Sparse and Dense Multidimensional Arrays
Authors@R: c(person("TileDB, Inc.", role = c("aut", "cph")),
person("Dirk", "Eddelbuettel", email = "dirk@tiledb.com", role = "cre"))
Expand Down
2 changes: 2 additions & 0 deletions R/TileDBArray.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -791,6 +791,8 @@ setMethod("[", "tiledb_array",
if (resrv == 0 && counter > 1L) {
finished <- TRUE
#if (verbose) message("Breaking loop at zero length expected")
if (status != "COMPLETE") warning("Query returned '", status, "'.", call. = FALSE)
.pkgenv[["query_status"]] <- status
break
}
## get results
Expand Down
3 changes: 3 additions & 0 deletions inst/tinytest/test_query.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,6 +232,7 @@ expect_equal(nv[3], n) # third is length of validity buffer (if
#})

## check for warning in insufficient memory
oldcfg <- tiledb_config()
cfg <- tiledb_config()
cfg["sm.memory_budget"] <- "16"
cfg["sm.memory_budget_var"] <- "32"
Expand All @@ -249,3 +250,5 @@ expect_true(nchar(res) > 1000) # safe lower boundary
res <- tiledb_ctx_stats() # test here rather than in test_ctx to have real query
expect_true(is.character(res))
expect_true(nchar(res) > 1000) # safe lower boundary

ctx <- tiledb_ctx(oldcfg) # reset config
7 changes: 7 additions & 0 deletions inst/tinytest/test_tiledbarray.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1418,3 +1418,10 @@ arr <- tiledb_array(uri, as.data.frame = TRUE, attrs = NA_character_)
res <- arr[]
expect_equal(NCOL(res), 2)
expect_equal(colnames(res), c("species", "year"))


## check for incomplete status on unsuccessful query
set_allocation_size_preference(256) # too low for penguins to return something
array <- tiledb_array(uri, as.data.frame=TRUE)
expect_warning(res <- array[]) # warning emitted
expect_equal(attr(res, "query_status"), "INCOMPLETE") # and query status reported