Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for OR query condition operations #417

Merged
merged 3 commits into from
Jun 7, 2022

Conversation

eddelbuettel
Copy link
Contributor

@eddelbuettel eddelbuettel commented May 24, 2022

This PR adds support for OR query condition operations via additional tests.

No code changes are needed, and documentation is updated.

Leaving this as a draft until OR support is merged. Now a proper PR.

@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #17917: Add support for OR query conditions.

@eddelbuettel eddelbuettel marked this pull request as ready for review June 7, 2022 17:54
Copy link
Member

@aaronwolen aaronwolen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🚢

Copy link
Member

@ihnorton ihnorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, LGTM!

@eddelbuettel eddelbuettel merged commit 5072545 into master Jun 7, 2022
@eddelbuettel eddelbuettel deleted the de/sc-17917/or_query branch June 7, 2022 18:01
@eddelbuettel eddelbuettel mentioned this pull request Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants