Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deal with arrays with the same name in BI tools #11

Merged

Conversation

DimitrisStaratzis
Copy link
Contributor

@DimitrisStaratzis DimitrisStaratzis commented Oct 4, 2023

This PR will solve the duplicate names issue. Every array listed also contains a small part of its UUID. (Tableau crops large array names that's why I am not putting the entire UUID like in a previous implementation). This part of the UUID is then used to fetch the entire tileDBURI from a static hash map.

Screenshot of both Tableau and Power BI below.

Screenshot 2023-10-04 at 6 22 45 PM Screenshot 2023-10-04 at 6 26 45 PM

@DimitrisStaratzis DimitrisStaratzis marked this pull request as draft October 4, 2023 11:28
@DimitrisStaratzis DimitrisStaratzis force-pushed the dstara/resolve_duplicate_array_names_in_bi_tools branch from 4059d53 to b990ece Compare October 4, 2023 15:28
@DimitrisStaratzis DimitrisStaratzis marked this pull request as ready for review October 4, 2023 15:36
Copy link
Member

@ihnorton ihnorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, let's try changing this to use a multimap so that we can handle the corner case of duplicated first-8 correctly.

@DimitrisStaratzis
Copy link
Contributor Author

DimitrisStaratzis commented Oct 5, 2023

As discussed, let's try changing this to use a multimap so that we can handle the corner case of duplicated first-8 correctly.

Caught this corner case by using a bidirectional hashmap. Duplicate short UUIDs will be appended with "-1", "-2" etc. This modified short-UUID will be used to display the arrays and map their tiledbURIs

@DimitrisStaratzis DimitrisStaratzis force-pushed the dstara/resolve_duplicate_array_names_in_bi_tools branch from 92161d8 to 08c3017 Compare October 5, 2023 14:46
@DimitrisStaratzis DimitrisStaratzis force-pushed the dstara/resolve_duplicate_array_names_in_bi_tools branch from 08c3017 to 32fbae5 Compare October 5, 2023 14:49
Copy link
Member

@ihnorton ihnorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@DimitrisStaratzis DimitrisStaratzis merged commit dd1ba51 into main Oct 5, 2023
@DimitrisStaratzis DimitrisStaratzis deleted the dstara/resolve_duplicate_array_names_in_bi_tools branch October 5, 2023 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants