fix refresh e.g. single backup/restore task #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backing up a single entry didn't get a refresh.
Additionally, I had a case where something wasn't refreshed because two refreshes were running in parallel (I tried to change this, but a Java Thread cannot be stopped from outside and from inside didn't work either, but that's another story).
Anyways, it doesn't make much sense to start a refresh thread before an action (especially when caching), so I removed this.
All refresh invocations are now at the end of some action.
I also added a TODO, because parallel refreshes only show the spinner while the first one is running, because it is reset after the each refresh (and it is only bool)