Format code and fix advanced search filter input eats key presses #8578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Confirmed: pmario has already signed the Contributor License Agreement (see contributing.md) |
pmario
changed the title
|
Thanks @pmario there are conflicts to resolve |
|
@Jermolene -- conflicts fixed and functionality tested |
|
Thanks @pmario |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR relys on PR: fix typing problem in advanced search filter tab #8577 -- So it should be merged after #8577
This PR is related to: [BUG] Search input in "Filter" tab in advanced search drops key presses as of 5.3.5 on Firefox #8551
The text input will register fast typing again. No matter how many results are shown. So
[all[]]does not cause any problems with typing anymore.But this PR does not explain why the problem happened in the first place.
I do have an idea, but no time to dig into the rabbit hole as @hoelzro did in #8551 -- It seems to be a refresh problem where a nested HTML element is involved.
This PR does:
emptyMessageinto the new<$list-empty>widget to improve code readabilitytag="div" class="tc-search-results"in the reveal-widget so the DIV could be removed