Use &Path instead of &str for path in write_to_path

src/components/flac_tag.rs

@@ -287,7 +287,7 @@ impl AudioTagWrite for FlacTag {
         self.inner.write_to(file)?;
         Ok(())
     }
-    fn write_to_path(&mut self, path: &str) -> crate::Result<()> {
+    fn write_to_path(&mut self, path: &Path) -> crate::Result<()> {
         self.inner.write_to_path(path)?;
         Ok(())
     }

src/components/id3_tag.rs

@@ -264,7 +264,7 @@ impl AudioTagWrite for Id3v2Tag {
         self.inner.write_to(file, id3::Version::Id3v24)?;
         Ok(())
     }
-    fn write_to_path(&mut self, path: &str) -> crate::Result<()> {
+    fn write_to_path(&mut self, path: &Path) -> crate::Result<()> {
         self.inner.write_to_path(path, id3::Version::Id3v24)?;
         Ok(())
     }

src/components/mp4_tag.rs

@@ -320,7 +320,7 @@ impl AudioTagWrite for Mp4Tag {
         self.inner.write_to(file)?;
         Ok(())
     }
-    fn write_to_path(&mut self, path: &str) -> crate::Result<()> {
+    fn write_to_path(&mut self, path: &Path) -> crate::Result<()> {
         self.inner.write_to_path(path)?;
         Ok(())
     }

src/lib.rs

@@ -35,6 +35,7 @@
 //!
 //! ```rust,no_run
 //! use audiotags::{Tag, Picture, MimeType};
+//! use std::path::Path;
 //!
 //! // using `default()` or `new()` alone so that the metadata format is
 //! // guessed (from the file extension) (in this case, Id3v2 tag is read)
@@ -58,7 +59,7 @@
 //! assert!(tag.album_cover().is_none());
 //! tag.remove_album_cover();
 //!
-//! tag.write_to_path("test.mp3").expect("Fail to save");
+//! tag.write_to_path(Path::new("test.mp3")).expect("Fail to save");
 //! ```
 
 pub(crate) use audiotags_macro::*;
@@ -93,14 +94,15 @@ pub use std::convert::{TryFrom, TryInto};
 ///
 /// ```no_run
 /// use audiotags::{Tag, TagType};
+/// use std::path::Path;
 ///
 /// # fn main() -> audiotags::Result<()> {
 /// // Guess the format by default
 /// let mut tag = Tag::new().read_from_path("assets/a.mp3").unwrap();
 /// tag.set_title("Foo");
 ///
 /// // you can convert the tag type and save the metadata to another file.
-/// tag.to_dyn_tag(TagType::Mp4).write_to_path("assets/a.m4a")?;
+/// tag.to_dyn_tag(TagType::Mp4).write_to_path(Path::new("assets/a.m4a"))?;
 ///
 /// // you can specify the tag type (but when you want to do this, also consider directly using the concrete type)
 /// let tag = Tag::new().with_tag_type(TagType::Mp4).read_from_path("assets/a.m4a").unwrap();

src/traits.rs

@@ -1,5 +1,6 @@
 use super::*;
 use id3::Timestamp;
+use std::path::Path;
 
 pub trait AudioTag: AudioTagEdit + AudioTagWrite + ToAnyTag {}
 
@@ -148,7 +149,7 @@ pub trait AudioTagEdit: AudioTagConfig {
 pub trait AudioTagWrite {
     fn write_to(&mut self, file: &mut File) -> crate::Result<()>;
     // cannot use impl AsRef<Path>
-    fn write_to_path(&mut self, path: &str) -> crate::Result<()>;
+    fn write_to_path(&mut self, path: &Path) -> crate::Result<()>;
 }
 
 pub trait AudioTagConfig {

tests/inner.rs

@@ -1,6 +1,7 @@
 use audiotags::*;
 use id3::TagLike;
 use std::fs;
+use std::path::Path;
 use tempfile::Builder;
 
 #[test]
@@ -24,7 +25,7 @@ fn test_inner() {
     let mut id3tag = tag.to_dyn_tag(TagType::Id3v2);
 
     id3tag
-        .write_to_path(tmp_path.to_str().unwrap())
+        .write_to_path(Path::new(tmp_path.to_str().unwrap()))
         .expect("Fail to write!");
 
     let id3tag_reload = Tag::default()