Add support for getting/setting comment #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently mack[0] only supports ID3 tags, and I'd like to allow it to also support FLAC and M4A. It currently uses the comment field as presented by rust-id3, but audiotags doesn't expose this. This commit adds support to that effect. 0: https://github.com/cdown/mack
cdown
force-pushed
the
cdown/2023-03-27/comment
branch
from
416a494 to
1e716be
Compare
Serial-ATA
reviewed
Apr 3, 2023
Co-authored-by: Alex <69764315+Serial-ATA@users.noreply.github.com>
|
@Serial-ATA this is good to go as well ? |
|
Yep, looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently mack[0] only supports ID3 tags, and I'd like to allow it to also support FLAC and M4A. It currently uses the comment field as presented by rust-id3, but audiotags doesn't expose this. This commit adds support to that effect.
0: https://github.com/cdown/mack