Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added DataCite metadata using PyCSW's latest version. #3

Merged
merged 9 commits into from
Dec 18, 2023
Merged

Added DataCite metadata using PyCSW's latest version. #3

merged 9 commits into from
Dec 18, 2023

Conversation

ahmdthr
Copy link

@ahmdthr ahmdthr commented Nov 23, 2023 •
edited
Loading

Resolves https://github.com/Thuenen-GeoNode-Development/Sprints/issues/5

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks: black geonode && flake8 geonode
  • Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates
  • Commits adding new texts do use gettext and have updated .po / .mo files (without location infos)

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@ahmdthr ahmdthr mentioned this pull request Nov 23, 2023
Closed
@ridoo ridoo mentioned this pull request Nov 28, 2023
Open
30 tasks
@ahmdthr ahmdthr marked this pull request as ready for review November 30, 2023 05:03
gannebamm
gannebamm reviewed Dec 4, 2023
View reviewed changes
setup.cfg Show resolved Hide resolved
gannebamm
gannebamm reviewed Dec 4, 2023
View reviewed changes
geonode/catalogue/backends/pycsw_local_mappings.py
@@ -77,6 +85,6 @@
"pycsw:Publisher": "publisher",
"pycsw:Contributor": "contributor",
"pycsw:Relation": "relation",
"pycsw:Links": "download_links",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please double check if this will lead to regressions

@gannebamm
Copy link

please check the pycsw test error owslib.ows.ExceptionReport: "Record serialization failed: name 'linkset' is not defined"
see: https://app.circleci.com/pipelines/github/Thuenen-GeoNode-Development/geonode/45/workflows/d8c01150-c55e-4a77-83c7-d07c39b90ac4/jobs/268?invite=true#step-106-71392_64

@ahmdthr
Copy link
Author

ahmdthr commented Dec 7, 2023

please check the pycsw test error owslib.ows.ExceptionReport: "Record serialization failed: name 'linkset' is not defined" see: https://app.circleci.com/pipelines/github/Thuenen-GeoNode-Development/geonode/45/workflows/d8c01150-c55e-4a77-83c7-d07c39b90ac4/jobs/268?invite=true#step-106-71392_64

This test error is due to an error on PyCSW 3.0. An issue (geopython/pycsw#924) and a PR (geopython/pycsw#925) has been created for PyCSW. This error is totally unrelated to what we did for DatCite metadata, in fact this error originates from FGDC metadata (which is not even used for GeoNode, we only have ISO and Dublin Core for now). I have temporarily disabled the failing test, and should be re-enabled once the PR is merged.

@ridoo
Copy link

ridoo commented Dec 7, 2023

@gannebamm currently the datacite feature is only in the master branch which is suboptimal for a productive deployment. However, I asked in the pycsw Gitter when the plan to release v3.0.

@ridoo
Copy link

ridoo commented Dec 9, 2023 •
edited
Loading

’v3’ will be released, once OGC API for Records has been finalized (of course, as pycsw is a reference implementation 🤦‍♂️).

However, DataCite feature and fixes made by @ahmdthr were merged and become available as alpha-5. @ahmdthr please take care to update and quick test the new alpha version.

@ahmdthr
Copy link
Author

ahmdthr commented Dec 11, 2023

’v3’ will be released, once OGC API for Records has been finalized (of course, as pycsw is a reference implementation 🤦‍♂️).

However, DataCite feature and fixes made by @ahmdthr were merged and become available as alpha-5. @ahmdthr please take care to update and quick test the new alpha version.

PR is updated with 3.0.0-alpha5

ridoo pushed a commit to Thuenen-GeoNode-Development/geonode-mapstore-client that referenced this pull request Dec 18, 2023
@ahmdthr
Adds download option for DataCite metadata format
7b21c14 
Adds download button for DataCite format.

This PR is related to the Thuenen-GeoNode-Development/geonode#3 which integrates pyCSW `v3` (as alpha) to provide DataCite download format on the backend.

Closes #27
@ridoo ridoo merged commit fb7ced3 into thuenen_4.x Dec 18, 2023
@ridoo ridoo changed the title Added DataCite metedata using PyCSW's latest version. Added DataCite metadata using PyCSW's latest version. Dec 18, 2023
@ahmdthr
Copy link
Author

ahmdthr commented Jan 22, 2024 •
edited
Loading

Fixed the issue of contacts not appearing in DataCite metadata. The URLs for contact's profile are still not appearing because of a bug in pycsw. A PR (geopython/pycsw#945) has been opened for this issue (geopython/pycsw#944).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gannebamm gannebamm gannebamm left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahmdthr @gannebamm @ridoo