Fix max_bin

ThomasMeissnerDS · Jul 3, 2024 · d3db45d · d3db45d
1 parent cd1b6f9
commit d3db45d
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/bluecast/config/training_config.py b/bluecast/config/training_config.py
@@ -127,8 +127,8 @@ class XgboostTuneParamsConfig(BaseModel):
     col_sample_by_tree_max: float = 1.0
     col_sample_by_level_min: float = 1.0
     col_sample_by_level_max: float = 1.0
-    max_bin_min: int = 256
-    max_bin_max: int = 25000
+    max_bin_min: int = 255
+    max_bin_max: int = 255
     eta_min: float = 1e-3
     eta_max: float = 0.3
     steps_min: int = 50
@@ -162,6 +162,8 @@ class XgboostTuneParamsRegressionConfig(BaseModel):
     col_sample_by_tree_max: float = 1.0
     col_sample_by_level_min: float = 1.0
     col_sample_by_level_max: float = 1.0
+    max_bin_min: int = 128
+    max_bin_max: int = 512
     eta_min: float = 1e-3
     eta_max: float = 0.3
     steps_min: int = 50

diff --git a/dist/bluecast-1.4.4-py3-none-any.whl b/dist/bluecast-1.4.4-py3-none-any.whl
diff --git a/dist/bluecast-1.4.4.tar.gz b/dist/bluecast-1.4.4.tar.gz