forked from gap-system/gap
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
deal with unwanted side-effects of gap-system#3006
- Let the filters created by `DeclareHandlingByNiceBasis` imply `IsFreeLeftModule`. This was the case before the changes from gap-system#3006, and this change fixes the problem described in gap-system#5322, as I had sketched in the discussion of gap-system#5325. - Document this change (following gap-system#5325). - Increase the rank of `IsHandledByNiceBasis` by 2. Then we get back to the rank before the changes from gap-system#3006. This way, the `\in` method with second argument in `IsFreeLeftModule and IsHandledByNiceBasis` is again ranked higher than the one with second argument `IsFreeLeftModule and IsFiniteDimensional`. The bug described in issue gap-system#5334 which has been found because of the reordering of these two methods (due to gap-system#3006) gets fixed via pull request gap-system#5335, now we can return to the better method ordering. (I do not like uprankings, but I have no better idea to solve this problem.)
- Loading branch information
1 parent
0adf6d1
commit 14d2c31
Showing
3 changed files
with
9 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters