96 report time between in days #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please complete the following information:
A reference to the issue addressed by this pull-request:
closes as.integer(.data$time_between) calculates time between dttms as seconds not days #96
A description of the changes proposed in this PR:
Converts internal processing of event data to POSIXct, not Date.
Correctly sets the difftime unit to days (it was previously implicitly seconds).
Minor change to remove event data that occurs after the report cutoff datetime.
Add @mentions for the people who will review this PR:
None.
Please confirm that you have:
devtools::test()and fixed all failing tests and warnings.suppressMessages()to any test message which breaks the test progress UI.Thank you for contributing to {SPCreporter}!!