Merged elastic#72256 and elastic#74253 in order to test panel reactiv…

…ity for by value embeddables
ThomThomson · Aug 17, 2020 · 9562949 · 9562949
1 parent 09381f3
commit 9562949
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/src/plugins/dashboard/public/application/embeddable/dashboard_container.tsx b/src/plugins/dashboard/public/application/embeddable/dashboard_container.tsx
@@ -199,11 +199,12 @@ export class DashboardContainer extends Container<InheritedChildInput, Dashboard
         explicitInput: {
           ...explicitInput,
           // TS does not catch up with the typeguard above, so it needs to be explicit
-          id: explicitInput.id,
+          id: idToReplace,
         },
       });
+    } else {
+      return this.addNewEmbeddable<EEI, EEO, E>(type, explicitInput);
     }
-    return this.addNewEmbeddable<EEI, EEO, E>(type, explicitInput);
   }
 
   public render(dom: HTMLElement) {