improvement(Depot)

[lomamech]

• Improve display in Allowed Destination Depots

closes #5713

[lomamech]

[mbayopanda]

Using checkbox and grid for allowed distribution depot is a good idea 👍🏽 it gives to the user much space to interact and it is more readable.

I just made a comment about the use of depotLeft and depotRight.

Is it still necessary to have depotLeft and depotRight while we use just one loop with <div ng-repeat ="r in DepotModalCtrl.depots" class="col-md-6">

[mbayopanda]

If depotLeft and depotRight are just for displaying depots left and right, you could use just one loop such as :

<div ng-repeat ="r in DepotModalCtrl.depots" class="col-md-6">
  <div class="checkbox">
    <label>
      <input type="checkbox" ng-model="r.checked" ng-true-value="1" ng-false-value="0">
      <span translate> {{ r.text }} </span>
    </label>
  </div>
</div>

[lomamech]

I tried with this option, the display stays on one column, my idea on concerning the two-column display was just not to have a very long list

[jmcameron]

Take a look at the answer to this: https://stackoverflow.com/questions/25655207/angularjs-how-to-dynamically-split-list-in-multiple-columns

[jniles]

FYI, you don't need to do this extra index. The second argument of Array.forEach() is an index like you made. So you can do this:

depots.forEach((depot, index) => {

// everything else 

});

[lomamech]

@mbayopanda can you check again

[lomamech]

@mbayopanda can you check again

@jmcameron I found another way to display on 2 columns

[jmcameron]

@jmcameron I found another way to display on 2 columns

Your approach looks pretty robust and automatic. Nice!

[jmcameron]

@lomamech How do I get to this display?

[jniles]

@jmcameron you'll need to enable restricting distribution depots. I think it is in stock settings, but it might be in the depot settings.

[jmcameron]

The update looks good and it works fine.

Minor suggestion: since the depots will be listed in two columns, perhaps the create depot modal should be a bit wider?

[jmcameron]

Looks like an extra leading space got into this string

[jniles]

LGTM. bors r+

[jniles]

bors r+

[bors]

Build succeeded:

• ci/semaphoreci/push: Integration Tests