fix(test): fix bh-date-editor tests #4970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jniles
force-pushed
the
fix-end-to-end-test-bh-date-edit
branch
3 times, most recently
from
c8dad2b to
57e14f6
Compare
jniles
force-pushed
the
fix-end-to-end-test-bh-date-edit
branch
from
57e14f6 to
4b18dad
Compare
jniles
commented
Oct 1, 2020
| @@ -17,7 +17,7 @@ class OffdayPage { | |||
| await FU.buttons.create(); | |||
| await FU.input('OffdayModalCtrl.offday.label', offday.label); | |||
|
|
|||
| components.dateEditor.set(new Date(offday.date), null, '[uib-modal] .title'); | |||
| await components.dateEditor.set(offday.date, 'offday-date-editor'); | |||
There was a problem hiding this comment.
If anyone is wondering, the critical change was putting an await in front of the component.
jniles
force-pushed
the
fix-end-to-end-test-bh-date-edit
branch
2 times, most recently
from
d15562c to
5128b55
Compare
jniles
force-pushed
the
fix-end-to-end-test-bh-date-edit
branch
2 times, most recently
from
bf1697e to
6d188f9
Compare
Cherry picked the bh-date-editor changes from Third-Culture-Software#4837 and add the critical await call to prevent test failures. Closes Third-Culture-Software#4919.
Make the integration tests pass by fixing a bug in the CMM calculation.
jniles
force-pushed
the
fix-end-to-end-test-bh-date-edit
branch
from
40212d3 to
3a6acf3
Compare
The security stock has become the minimum stock for a product. Not sure why.
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry picked the bh-date-editor changes from #4837 to bring them into
mastersooner.Closes #4919.