Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version and root check #326

Merged
merged 3 commits into from
Jan 7, 2022
Merged

version and root check #326

merged 3 commits into from
Jan 7, 2022

Conversation

lolpro11
Copy link
Contributor

@lolpro11 lolpro11 commented Jan 4, 2022

  • Added a check to see if script is run as the root user.
  • Added the ability to check and download the latest version.
  • Added a check to see if python is already installed.
  • Added a check to see if pip is already installed.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project and have read CONTRIBUTING.md
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@ThioJoe ThioJoe added the in-review Request acknowledged but not yet fully reviewed label Jan 4, 2022
@TechStudent10
Copy link
Contributor

Why do you need to check if the user is root?

@Firecul
Copy link
Contributor

Firecul commented Jan 6, 2022

To allow installing the dependencies most likely.

@lolpro11
Copy link
Contributor Author

lolpro11 commented Jan 6, 2022

Why do you need to check if the user is root?

Package managers need root permission.

else
echo "Looks like you aren't running this installer on a Debian, Ubuntu, Fedora, CentOS, Arch Linux system."
exit 1
echo "Did not unistall jq as it was preinstalled before running this script."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Did not uninstall jq ..."

else
echo "Looks like you aren't running this installer on a Debian, Ubuntu, Fedora, CentOS, Arch Linux system."
exit 1
echo "Did not unistall jq as it was preinstalled before running this script."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Did not uninstall jq..."

@TechStudent10
Copy link
Contributor

@Firecul @lolpro11 Thanks for responding. I totally forgot package managers needed root. But why not just run sudo outright?

@lolpro11
Copy link
Contributor Author

lolpro11 commented Jan 7, 2022

@Firecul @lolpro11 Thanks for responding. I totally forgot package managers needed root. But why not just run sudo outright?

I decided to do that, and I fixed the checking for python and jq.

@ThioJoe Please update Linux Installation Instructions Step No.3 to ./install.sh

@ThioJoe ThioJoe merged commit b13743b into ThioJoe:main Jan 7, 2022
@ThioJoe
Copy link
Owner

ThioJoe commented Jan 7, 2022

Ok done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in-review Request acknowledged but not yet fully reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants