-
Notifications
You must be signed in to change notification settings - Fork 390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solution for Unsupported Devices / Android Users to be able to run code #118
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per @ThioJoe's comment on #116 , I think instead of calling:
pip install rtfunicode
pip install colorama
pip install google-api-python-client
We just need to call upon the requirements.txt file, although for now as I have tested this I'm leaving it as it is, but if we can cut out these 3 lines of code and replace it with one line, that would be good, but I just need to complete my testing on this.
@ThioJoe I just tested it and it works, please request changes for updating this! |
I figured out how to commit without you having to request changes. Please merge Removed 3 pips, made it into 1 to main. |
@KendallDoesCoding maybe edit the description to say:
|
Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<p>pip install -r requirements.txt</p>
should just be:
```bash
pip install -r requirements.txt
With an ending of ```.
Well, it worked with what I put, Should I update it to pip install -r requirements.txt``` What does the ``` stand for @TechStudent11 ? |
It means "code block". You know, this: print("Hi mom!") |
Oh ok, first lemme test it, if it works, I'll edit it. You can create a
pull request in my forked version of the repo
https://github.com/KendallDoesCoding/YouTube-Spammer-Purge
In branch, patch 3
…On Tue, 7 Dec 2021 at 17:52, TechStudent10 ***@***.***> wrote:
It means "code block".
You know, this:
print("Hi mom!")
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#118 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AUGJUTP57HKNMQSFA5TL7ETUPX4B7ANCNFSM5JPCTTFA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ThioJoe If you want, you can get rid of the pip install -r requirements.txt line, and edit it to be, follow installation mentioned above
above = above on README.md
With this, Idk if its working or not, but it doesn't print out if its installing or no. |
@ThioJoe Waiting for your reply... What do you think on this? |
@ThioJoe Can you please review this, put the comment in the wrong PR. |
I'll have to look into this, I try to minimize recommending third party services when possible. Also need to make sure it works with the GUI portion |
Yeah, I don't like using third party services too, but to make everything
much easier for Linux and possibly Android users, I think this is a good
option. Ofc, feel free to review this!
…On Thu, 9 Dec 2021 at 21:34, ThioJoe ***@***.***> wrote:
I'll have to look into this, I try to minimize recommending third party
services when possible. Also need to make sure it works with the GUI portion
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#118 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AUGJUTNYBGXYSETXPADY4X3UQDHSPANCNFSM5JPCTTFA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
Because, rn we are getting lots of complaints from Linux users, who don't
understand how to set it up.
On Thu, 9 Dec 2021 at 21:36, Kendall Pinto ***@***.***>
wrote:
… Yeah, I don't like using third party services too, but to make everything
much easier for Linux and possibly Android users, I think this is a good
option. Ofc, feel free to review this!
On Thu, 9 Dec 2021 at 21:34, ThioJoe ***@***.***> wrote:
> I'll have to look into this, I try to minimize recommending third party
> services when possible. Also need to make sure it works with the GUI portion
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#118 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AUGJUTNYBGXYSETXPADY4X3UQDHSPANCNFSM5JPCTTFA>
> .
> Triage notifications on the go with GitHub Mobile for iOS
> <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
> or Android
> <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
>
>
|
I can do a screen recording to show how it works for you @ThioJoe.
On Thu, 9 Dec 2021 at 21:36, Kendall Pinto ***@***.***>
wrote:
… Because, rn we are getting lots of complaints from Linux users, who don't
understand how to set it up.
On Thu, 9 Dec 2021 at 21:36, Kendall Pinto ***@***.***>
wrote:
> Yeah, I don't like using third party services too, but to make everything
> much easier for Linux and possibly Android users, I think this is a good
> option. Ofc, feel free to review this!
>
> On Thu, 9 Dec 2021 at 21:34, ThioJoe ***@***.***> wrote:
>
>> I'll have to look into this, I try to minimize recommending third party
>> services when possible. Also need to make sure it works with the GUI portion
>>
>> —
>> You are receiving this because you were mentioned.
>> Reply to this email directly, view it on GitHub
>> <#118 (comment)>,
>> or unsubscribe
>> <https://github.com/notifications/unsubscribe-auth/AUGJUTNYBGXYSETXPADY4X3UQDHSPANCNFSM5JPCTTFA>
>> .
>> Triage notifications on the go with GitHub Mobile for iOS
>> <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
>> or Android
>> <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
>>
>>
>
|
Frankly if someone is using linux they should be able to figure out how to install python |
Yes, but as we can see from the issues, that's not the case. I think people
these days, just download Linux, without knowing how to use it lol
…On Thu, 9 Dec 2021 at 21:41, ThioJoe ***@***.***> wrote:
Frankly if someone is using linux they should be able to figure out how to
install python
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#118 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AUGJUTLXOQPB5JIHXSAMN2LUQDIJ7ANCNFSM5JPCTTFA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
@ThioJoe I'm getting a error, but I just think it's a code error, I'm creating a issue thread. |
@TechStudent11 Tell me if you know how to sort this out, otherwise I will close this PR. |
I'm trying it out again, I have a weird glitch with my chrome! |
@TechStudent11 , @ThioJoe Nay, doesn't work |
It's a KeyboardInterupt. You pressed |
But, I didnt see anything in the window that opened too, which said login
to the window.
…On Fri, 10 Dec 2021 at 02:56, TechStudent10 ***@***.***> wrote:
It's a KeyboardInterupt. You pressed Ctrl+C.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#118 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AUGJUTLADVR44KZ6G7PGPEDUQENGZANCNFSM5JPCTTFA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
@KendallDoesCoding ? Anyways, I'm going to bed now. It's about 10 PM. Actually, it's to 11. |
No problem, yeah 10 and a half hours difference, It will be 11 in 5 minutes.
…On Fri, 10 Dec 2021 at 09:18, TechStudent10 ***@***.***> wrote:
But, I didnt see anything in the window that opened too, which said login
to the window.
@KendallDoesCoding <https://github.com/KendallDoesCoding> ? Anyways, I'm
going to bed now. It's about 10 PM. Actually, it's to 11.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#118 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AUGJUTIZ3VKGF2Q5Q2QO5PTUQF2BLANCNFSM5JPCTTFA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
I don't think I want to officially support a method that requires people to upload or store their authentication credentials on a third party site |
I guess you're right, yeah. |
Yup, I get what you mean. I didn't think of that until you said this. Also, it anyway doesn't seem to be working so I'm closing this ticket. I just thought it would be a good idea, because we are getting lots of reports saying its not running for Linux. |
@ThioJoe I think the online version of VS Code would work, I don't think of it as a third party service, because if I couldn't run .exe files, I would just run it in VS Code, although, I can't figure out how to run python there. @TechStudent11 , @ThioJoe Let me know if you can figure out how to, the url for the vscode online is here - https://vscode.dev/github/ThioJoe/YouTube-Spammer-Purge It should have the github repo already opened, it worked for me. |
I changed the README.md to this for the time-being, obviously it wont stay like this if we figure out how we can run the code in vs code's online website. |
You can't. vscode.dev can't run terminals. If you want to do that, you need a Codespace, which costs money. |
Isn't Github Codespaces free?
…On Sat, 11 Dec 2021 at 22:46, TechStudent10 ***@***.***> wrote:
You can't. vscode.dev can't run terminals. If you want to do that, you
need a Codespace, which costs money.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#118 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AUGJUTMC2TEQI6WTKAYY2X3UQOBQXANCNFSM5JPCTTFA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
@KendallDoesCoding Not it isn't. github.dev might be what you're thinking about. That's the online GitHub editor. Codespaces on the other hand, makes you pay for VMs to write your code on. |
Got it! |
@ThioJoe Do you know any IDE software that let's you run code online? |
It seems like no... Closing this PR, again! |
Uhhh....android users can just use termux, a linux terminal emulator that can run and install actual linux software... |
Oh wow, interesting. I would mention this to the README file. But, idk how it works and @ThioJoe mentioned he doesn't like inculding third party services. So yeah. But good to know! |
Actually, let me delete branch. |
Updates pull request from #117
Many people are complaining, that they cannot run the code on Linux and that they cannot run the program at all on Android (which is obvious why for Android), so I added a way for Android users to run this program too, and Linux users to run this program too and edit the code too.
I think Linux is a major concern if .exe doesn't run on the OS and if the code had different variations between Windows and Linux.
@ThioJoe , if you want, you can add another txt file with my instructions instead of it being in the README.md
Fixes #110