Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update panel size max for sidebar #466

Merged
merged 5 commits into from
Jul 19, 2023
Merged

Conversation

JedWatson
Copy link
Member

This isn't a particularly big change or comprehensive fix or anything, but it's been annoying me that when I resize windows, the navigation sidebar always ends up too big and then I have to drag it smaller.

So after some tinkering (you're right @jossmac this is really fiddly) I ended up just reducing the maximums to make it "feel better". Let's shrink it and see if anyone comes up with a use-case for it to be meaningfully wider than the new max?

Otherwise it really eats into content entry space when you resize the window, on a normal 13" screen viewport.

Before:

image

After:

image

@JedWatson JedWatson requested a review from emmatown as a code owner July 18, 2023 12:31
@changeset-bot
Copy link

changeset-bot bot commented Jul 18, 2023

🦋 Changeset detected

Latest commit: 52da8cd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@keystatic/core Patch
@example/astro Patch
@example/localization Patch
@example/next-app Patch
@keystatic/remix-test-app Patch
keystatic-docs Patch
@keystatic/templates-astro Patch
@keystatic/templates-nextjs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jul 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
keystar-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 19, 2023 5:30am
keystatic ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 19, 2023 5:30am
keystatic-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 19, 2023 5:30am

Copy link
Member

@jossmac jossmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, the percentage API isn't appropriate. Unfortunately the author will not support pixel dimensions: 46, 47, 78, 114...

I need to roll a bespoke implementation, but it's not priority.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants