Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

close #678 #688

Merged
merged 2 commits into from
Jun 4, 2021
Merged

close #678 #688

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6c32ca2
Fixed check warning when using `golem::use_utils_server()`, close #678
ColinFay Jun 4, 2021
4988f14
Forgot some ...
ColinFay Jun 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@

+ recommended tests now use `expect_type()` instead of `expect_is`, which was deprecated from `{testthat}` (#671)

+ Fixed check warning when using `golem::use_utils_server()` (#678)

## Internal changes

# golem 0.3.1 (CRAN Version)
Expand Down
4 changes: 2 additions & 2 deletions inst/utils/golem_utils_server.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,6 @@ drop_nulls <- function(x){
#' @inheritParams reactiveValuesToList
#'
#' @noRd
rv <- shiny::reactiveValues
rvtl <- shiny::reactiveValuesToList
rv <- function(...) shiny::reactiveValues(...)
rvtl <- function(...) shiny::reactiveValuesToList(...)