Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfixing a bug with utils_download_file (#1168) #1169

Merged
merged 4 commits into from
Aug 27, 2024
Merged

Hotfixing a bug with utils_download_file (#1168) #1169

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
acbaea4
Re-build README.md
ColinFay Aug 16, 2024
8372c4e
Re-build README.md
ColinFay Aug 19, 2024
705b6e1
fix: fixing issue with recursive utils_download_file
ColinFay Aug 27, 2024
dcd16a9
Re-build README.md
ColinFay Aug 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DESCRIPTION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Package: golem
Title: A Framework for Robust Shiny Applications
Version: 0.5.0
Version: 0.5.1
Authors@R: c(
person("Colin", "Fay", , "contact@colinfay.me", role = c("cre", "aut"),
comment = c(ORCID = "0000-0001-7343-1846")),
Expand Down
4 changes: 4 additions & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
> Notes: the # between parenthesis refers to the related issue on GitHub, and the @ refers to an external contributor solving this issue.

# golem 0.5.1

* Hotfixing a bug with utils_download_file (#1168)

# golem 0.5.0

## New functions
Expand Down
4 changes: 0 additions & 4 deletions R/use_files.R
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,3 @@
# For mocking in test
utils_download_file <- function(...){
utils_download_file(...)
}
#' Use Files
#'
#' These functions download files from external sources and put them inside the `inst/app/www` directory.
Expand Down
10 changes: 5 additions & 5 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ status](https://www.r-pkg.org/badges/version/golem)](https://cran.r-project.org/

# {golem} <img src="https://raw.githubusercontent.com/ThinkR-open/golem/master/inst/rstudio/templates/project/golem.png" align="right" width="120"/>

> You’re reading the doc about version: 0.5.0. Note that `{golem}`
> You’re reading the doc about version: 0.5.1. Note that `{golem}`
> follows the [semantic versioning](https://semver.org/) scheme.

Production-grade `{shiny}` applications, from creation to deployment.
Expand Down Expand Up @@ -78,14 +78,14 @@ with blogposts, and links to other packages of the `golemverse`.
This `README` has been compiled on the

Sys.time()
#> [1] "2024-08-16 12:38:26 UTC"
#> [1] "2024-08-27 09:39:59 UTC"

Here are the test & coverage results:

devtools::check(quiet = TRUE)
#> ℹ Loading golem
#> ── R CMD check results ──────────────────────────────────────── golem 0.5.0 ────
#> Duration: 44.9s
#> ── R CMD check results ──────────────────────────────────────── golem 0.5.1 ────
#> Duration: 44.8s
#>
#> 0 errors ✔ | 0 warnings ✔ | 0 notes ✔

Expand All @@ -109,7 +109,7 @@ Here are the test & coverage results:
#> R/install_dev_deps.R: 78.26%
#> R/add_r_files.R: 78.70%
#> R/config.R: 79.23%
#> R/use_files.R: 80.40%
#> R/use_files.R: 80.63%
#> R/reload.R: 84.69%
#> R/disable_autoload.R: 85.00%
#> R/add_dockerfiles.R: 87.10%
Expand Down