Update expect_is to expect_type

[ColinFay]

The current test-golem-recommended throws a warning, as expect_is was deprecated in the latest version of testthat.

[ColinFay]

Another can be expect_equal(class(server), "function")

[ALanguillaume]

There are still some calls to expect_this lingering in dev

bob@lemur:~/projects/golem (dev) 
$ grep -rn "expect_is" tests/*
tests/testthat/test-js.R:2:  expect_is(activate_js(),'shiny.tag')
tests/testthat/test-favicon.R:43:    expect_is(
tests/testthat/test-make_dev.R:24:    expect_is(print_dev("test"), "character")
tests/testthat/test-make_dev.R:36:    expect_is(sum_dev(1,2), "numeric")
tests/testthat/test-make_dev.R:37:    expect_is(sum_dev, "function")
tests/testthat/test-make_dev.R:47:    expect_is(print_dev("test"), "character")

expect_type() won't work in all cases, expect_s3_class will be necessary at times.

[ALanguillaume]

My bad this concerns {golem} itself not test-golem-recommended. I will open a dedicated issue.