Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds uninstaller, fix a bug and adjust some things. Fix #3 #30

Merged
merged 4 commits into from
Aug 19, 2023

Conversation

Wolfmyths
Copy link
Contributor

Found and fixed a serious bug where batchPatch wasn't defined.

I created an uninstaller which has it's own .exe, it uses a lot of reused code from setup.py #3

I also noticed that .zips and the extracted version of hoi4-presence.zip wasn't included in .gitignore, so I added those

Wolfmyths and others added 2 commits August 14, 2023 13:41
+ Fixed traceback where batchPatch wasn't defined
+ Added uninstaller
+ Added a couple lines to .gitignore
@ThiaudioTT ThiaudioTT self-requested a review August 14, 2023 18:19
@ThiaudioTT ThiaudioTT linked an issue Aug 14, 2023 that may be closed by this pull request
@ThiaudioTT
Copy link
Owner

Nice

@ThiaudioTT ThiaudioTT added the QA We need to test it label Aug 17, 2023
Copy link
Owner

@ThiaudioTT ThiaudioTT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an error in the documents path.

src/uninstall.py Outdated Show resolved Hide resolved
@ThiaudioTT ThiaudioTT removed the QA We need to test it label Aug 19, 2023
@ThiaudioTT ThiaudioTT changed the title Added uninstaller, fixed bug, and added to .gitignore Adds uninstaller, fix a bug and adjust some things. Fix #3 Aug 19, 2023
@ThiaudioTT ThiaudioTT self-requested a review August 19, 2023 22:00
@ThiaudioTT ThiaudioTT merged commit 8eb06fd into ThiaudioTT:main Aug 19, 2023
@ThiaudioTT
Copy link
Owner

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uninstaller
2 participants