Set large_image via web #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved countries.json to src/discordRPC Deleted requestflag.py and integrated getFlag() into countries.py
Made the switch statement in getCountry() into a dictionary If a country isn't in the dictionary, it will create a new entry to prevent crashing. Changed a country variable to countryName as it would cause a traceback when accessing the countries dict Added a __str__ method to the Country class for debugging
Added every single country and most links to their respective flag images Some countries did not have wiki pages, these links will be added in a later commit The countries are ordered in the same order as they are on the wiki's list of countries Countries that have irregular data are put at the top of the dict
getCountry() now checks if the img string is empty, and will then set the country to HOI_ICON Changed single quotes to double [D##][0] is now civil war country Added comments about missing images and images that are really small Found flag links for most of the remaining countries (The ones with a imgur link may be a modern img of the flag) Renamed some misleading country names
All links for every country is now added Adjusted CIN country name Images that were labeled small now have higher res versions USB uses the US flag img BAS uses the UK flag img Both of these countries I could not find an image for anywhere
Removed trailing whitespace on line 5 Changed fr string to a r string
This was referenced Jul 17, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for Issue #12
Added a dictionary that includes every country in the game
Added a
__str__method to thecountryclassThe image links are either from imgur or the hoi4 wiki
I don't know if .gif files are supported, so
"KHA"needs to be testedDetails of this PR is found in commits starting at "Made switch statement into dict, added str()"