Verify if required files are in /dist/ and removed pathlib dependency #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for opening the PR. I will test and review it when possible |
ThiaudioTT
reviewed
Jul 3, 2023
ThiaudioTT
requested changes
Jul 3, 2023
|
Also update version.json in the root folder, this is an enhancement. So update to v0.3.0 |
|
I created a page that can help: https://github.com/ThiaudioTT/hoi4-presence/wiki/Folder-structure |
Now checks if runRPC.bat is valid Added variable for the batch folder path Added exception handling for not being able to find the batch folder Made os.listdir(source) in a with statement so it wasn't called more than once within the for loop Made exceptions easier to read Updated version.json to 0.3.0
ThiaudioTT
reviewed
Jul 4, 2023
Changed runRPC.bat to be in src\discordRPC and updated code in setup.py Removed \batch\ and updated code in setup.py Updated path in runRPC.bat line 5 to not depend on the .bat's file location Reverted changes to src\version.json and applied them to the correct version.json
ThiaudioTT
requested changes
Jul 8, 2023
Reverted changes to runRPC.bat from prev commit Removed with statement in setup.py Made else exception easier to signify that's there's an error by adding an "Error:" prefix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw these as TODO so I thought I would give them a shot.
Related to #9
setup.pysourcevariable fromline 72toline 29as it is needed there firstpathlibdependency withos.path