Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve email validation regex in Login and SignUp screens #1107

Merged
merged 5 commits into from
Dec 27, 2024

Conversation

Richie911
Copy link

Description

This PR is aimed at improving the regex for email validation to include emails like city.texas@gmail.com

Copy link

vercel bot commented Dec 25, 2024

@Richie911 is attempting to deploy a commit to the Streamability Team on Vercel.

A member of the Team first needs to authorize it.

@Richie911 Richie911 force-pushed the 1105-email-validation-bug branch from 42ee345 to a65f94d Compare December 25, 2024 16:28
Copy link

vercel bot commented Dec 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
streamability ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 27, 2024 3:17pm

Copy link
Owner

@Thenlie Thenlie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! The regex seems to work well on my end. My only improvement suggestion is that we make the regex shared between the login and signup screen. Likely placed in https://github.com/Thenlie/Streamability/blob/main/src/helpers/validationUtils.ts.

I am more than happy to merge this PR as is, but let me know if you would like to make thia change.

@Thenlie Thenlie added the type: bug Something isn't working label Dec 26, 2024
@Thenlie Thenlie linked an issue Dec 26, 2024 that may be closed by this pull request
@Thenlie Thenlie added this to the 2.1.0 milestone Dec 26, 2024
@Richie911 Richie911 force-pushed the 1105-email-validation-bug branch from a65f94d to dd2b441 Compare December 26, 2024 22:28
@Richie911
Copy link
Author

@Thenlie, that makes sense; I will get that done asap

@Richie911 Richie911 force-pushed the 1105-email-validation-bug branch from dd2b441 to f8aca24 Compare December 26, 2024 22:37
@Richie911
Copy link
Author

@Thenlie , the changes are ready

@Thenlie
Copy link
Owner

Thenlie commented Dec 27, 2024

@Richie911 The changes look great! The CI check is failing though due to the TODO file being out of date. Please run npm run todo-ci and commit the result. I will get this merged after that. Thanks!

@Richie911
Copy link
Author

@Thenlie , I did run the npm run todo-ci and committed the changes but the CI still failed

@Thenlie Thenlie merged commit 17fdad0 into Thenlie:develop Dec 27, 2024
3 of 4 checks passed
@Thenlie
Copy link
Owner

Thenlie commented Dec 27, 2024

I did run the npm run todo-ci and committed the changes but the CI still failed

There are still some issues with the CI on fork PRs, but we can ignore the other failures for now. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

🐞 Email validation bug
2 participants