-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve email validation regex in Login and SignUp screens #1107
Conversation
@Richie911 is attempting to deploy a commit to the Streamability Team on Vercel. A member of the Team first needs to authorize it. |
42ee345
to
a65f94d
Compare
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! The regex seems to work well on my end. My only improvement suggestion is that we make the regex shared between the login and signup screen. Likely placed in https://github.com/Thenlie/Streamability/blob/main/src/helpers/validationUtils.ts.
I am more than happy to merge this PR as is, but let me know if you would like to make thia change.
a65f94d
to
dd2b441
Compare
@Thenlie, that makes sense; I will get that done asap |
dd2b441
to
f8aca24
Compare
@Thenlie , the changes are ready |
@Richie911 The changes look great! The CI check is failing though due to the TODO file being out of date. Please run |
@Thenlie , I did run the npm run todo-ci and committed the changes but the CI still failed |
There are still some issues with the CI on fork PRs, but we can ignore the other failures for now. Thank you! |
Description
This PR is aimed at improving the regex for email validation to include emails like city.texas@gmail.com