-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(android): remove pausePlayback when audio focus loss event #3496
fix(android): remove pausePlayback when audio focus loss event #3496
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with that, this behavior is an application choice !
@KrzysztofMoch @YangJonghun I think again of this patch, I think it will cause some regressions ... |
@freeboub
|
@YangJonghun Ok, I understand correctly the request know! |
This reverts commit b1ab0f2.
Update the documentation
fix(android): remove pausePlayback when audio focus loss event
Update the changelog
fix(android): remove pausePlayback when audio focus loss event
Describe the changes
pausePlayback is added within PR #1897 (commit 1ab82f7)
but, it makes unintended pauses can be happen with below flow
source ready(auto play) -> pause -> play