Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a mistake in the documentation about the Headers. #1420

Merged
merged 1 commit into from
Jan 22, 2019

Conversation

rinonb
Copy link
Contributor

@rinonb rinonb commented Jan 10, 2019

A small change in the documentation regarding headers.

The "headers" property was listed as:

headers={{
  Authorization: 'bearer some-token-value',
  'X-Custom-Header': 'some value'
}}

Which makes it look like it's a prop, but in reality, is just a property of the source object.

source={{
  uri: "https://www.example.com/video.mp4",
  headers: {
    Authorization: 'bearer some-token-value',
    'X-Custom-Header': 'some value'
  }
}}

Copy link
Contributor

@n1ru4l n1ru4l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

@n1ru4l n1ru4l merged commit 59783f0 into TheWidlarzGroup:master Jan 22, 2019
AnteWall pushed a commit to sfstudios/react-native-video that referenced this pull request Mar 1, 2019
beauner69 pushed a commit to beauner69/react-native-video that referenced this pull request Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants