Android - Keep screen on #1117

geriux · 2018-07-10T13:10:56Z

Even though setScreenOnWhilePlaying is set to true in the MediaPlayer, on Android the screen will dim depending on the time the user has set on their phone.

It was already reported in this issue #744.

This will prevent the screen to turn off while a video is playing and it only affects the Android platform.

fluiddot

💯

cobarx · 2018-07-10T18:39:07Z

Thanks for pointing this out and creating a fix.

I haven't gotten to test this, so please excuse if I'm not up to speed. I think the ideal behavior is that the screen stays on while you're playing the video, but if you pause the video the screen should be allowed to go to sleep as that's what other video apps do. If we set this flag, will the screen go to sleep while paused?

Also, is this a problem on ExoPlayer as well? If so, would you mind creating a PR for that.

geriux · 2018-07-11T10:31:35Z

You're right @cobarx the screen should be allowed to go to sleep if the video is paused so I changed the code to take that into account as well :) let me know what you think.

As for the ExoPlayer I can't check it at the moment but I'll try to soon.

Thanks!

cobarx · 2018-07-12T17:37:45Z

Thanks for tackling the pause conditions. Is there a reason we need to check the current state of the flag rather than applying the appropriate value any time we play or pause? It adds quite a bit of code & complexity unless there's a compelling need for it (like performance).

geriux · 2018-07-19T16:09:59Z

Hi! I had a comment in my e-mail about this being fixed in another PR but i've just tested it and it is still happening with the latest version. Also I don't see your comment here :D do you still want me to continue with this PR? Let me know!

cobarx · 2018-07-20T20:47:59Z

@geriux I posted in the wrong PR, that comment was meant to go in the one about the iOS hanging while loading.

Yes, I would like to get this included. Can you simplify the logic so that it's more straightforward? Unless there's a good reason to do otherwise, it's much simpler to set and clear the flag every time rather than tracking the current state.

djw27 · 2018-07-23T13:35:57Z

See here for how it could potentially be simplified: https://github.com/corbt/react-native-keep-awake/blob/master/android/src/main/java/com/corbt/keepawake/KCKeepAwake.java

geriux · 2018-07-23T13:37:20Z

@cobarx alright! I'll simplify it and update the PR =)

cobarx

I've added a fix for one bug and also included some examples of how to simplify the code.

cobarx · 2018-07-24T17:28:41Z

android/src/main/java/com/brentvatne/react/ReactVideoView.java

+    }
+
+    public void setPreventScreenFromDimmingFlag(final boolean state) {
+        if (!mMediaPlayerValid && mThemedReactContext == null) {


This should be !mMediaPlayerValid || mThemedReactContext == null

cobarx · 2018-07-24T17:30:03Z

android/src/main/java/com/brentvatne/react/ReactVideoView.java

+            return;
+        }
+
+        final boolean isFlagOn = isPreventScreenFromDimmingFlagOn();


I would remove this check and simply apply the flag every time.

cobarx · 2018-07-24T17:31:09Z

android/src/main/java/com/brentvatne/react/ReactVideoView.java

+    public boolean isPreventScreenFromDimmingFlagOn() {
+        int flags = mThemedReactContext.getCurrentActivity().getWindow().getAttributes().flags;
+
+        if ((flags & WindowManager.LayoutParams.FLAG_KEEP_SCREEN_ON) == 0) {


If we need to keep this check for performance or other reasons, it can be written as:
return flags & WindowManager.LayoutParams.FLAG_KEEP_SCREEN_ON == 0

…act-native-video # Conflicts: # android/src/main/java/com/brentvatne/react/ReactVideoView.java

…plified code

…final

geriux · 2018-07-25T08:51:48Z

Thank you for the suggestions @cobarx ! I've fixed the bug and removed the check of the flag. Let me know what you think =)

cobarx · 2018-08-06T00:35:12Z

Sorry for the delay in getting this merged. I kept forgetting to bring along my cable when going to coffee shops and there's no way to test without using a real device #smh

I went ahead and switched this over to setKeepScreenOn since it's much simpler and matches what we're using on the ExoPlayer side. We also need to check for when the video ends and allow the screen to sleep if the video isn't on repeat. I tested and it works great.

I'm glad you brought this up, this is pretty important behavior, I have no idea how people got around this. Maybe everybody was using other modules to control sleeping.

tkstang · 2020-04-09T19:05:14Z

Is there a prop I need to pass in for this fix to work? I am still having this issue.

auseika · 2020-04-14T15:30:45Z

Would be great to have a way to disable this, since sometimes video is just a background.

sadikyalcin · 2021-01-28T17:33:55Z

Is there a prop I need to pass in for this fix to work? I am still having this issue.

This is still an issue for me too.

mehthabux · 2021-03-11T10:19:39Z

any update for exoplayer ?

mezalejandro · 2024-03-04T20:47:50Z

Hello,
This still doesn't work in version 6.0.0-beta.5,
any solution?

Android keep screen on

240444c

fluiddot approved these changes Jul 10, 2018

View reviewed changes

Android: MediaPlayer - Prevent screen from dimming

2f0b694

cobarx suggested changes Jul 24, 2018

View reviewed changes

Gerardo Pacheco added 4 commits July 25, 2018 09:58

Merge branch 'master' of https://github.com/react-native-community/re…

5435e5d

…act-native-video # Conflicts: # android/src/main/java/com/brentvatne/react/ReactVideoView.java

Android: MediaPlayer - Prevent screen from dimming, fixed bug and sim…

7e5647d

…plified code

Android: MediaPlayer - Prevent screen from dimming, check for activity

ab273ed

Android: MediaPlayer - Prevent screen from dimming, make variable as …

99591e4

…final

cobarx added 2 commits August 5, 2018 17:27

Switch to using setKeepScreenOn to prevent screen timeouts

bd48a00

Allow screen to sleep when video finishes

3a1d819

cobarx merged commit 7854a23 into TheWidlarzGroup:master Aug 6, 2018

cobarx mentioned this pull request Aug 6, 2018

[android] Screen dims & locks while video is playing #744

Closed

zhulduz mentioned this pull request Oct 16, 2019

Android - Keep screen on for Exoplayer #1798

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Android - Keep screen on #1117

Android - Keep screen on #1117

geriux commented Jul 10, 2018

fluiddot left a comment

cobarx commented Jul 10, 2018

geriux commented Jul 11, 2018

cobarx commented Jul 12, 2018

geriux commented Jul 19, 2018

cobarx commented Jul 20, 2018

djw27 commented Jul 23, 2018

geriux commented Jul 23, 2018

cobarx left a comment

cobarx Jul 24, 2018

cobarx Jul 24, 2018

cobarx Jul 24, 2018

geriux commented Jul 25, 2018

cobarx commented Aug 6, 2018

tkstang commented Apr 9, 2020

auseika commented Apr 14, 2020

sadikyalcin commented Jan 28, 2021

mehthabux commented Mar 11, 2021

mezalejandro commented Mar 4, 2024

Android - Keep screen on #1117

Android - Keep screen on #1117

Conversation

geriux commented Jul 10, 2018

fluiddot left a comment

Choose a reason for hiding this comment

cobarx commented Jul 10, 2018

geriux commented Jul 11, 2018

cobarx commented Jul 12, 2018

geriux commented Jul 19, 2018

cobarx commented Jul 20, 2018

djw27 commented Jul 23, 2018

geriux commented Jul 23, 2018

cobarx left a comment

Choose a reason for hiding this comment

cobarx Jul 24, 2018

Choose a reason for hiding this comment

cobarx Jul 24, 2018

Choose a reason for hiding this comment

cobarx Jul 24, 2018

Choose a reason for hiding this comment

geriux commented Jul 25, 2018

cobarx commented Aug 6, 2018

tkstang commented Apr 9, 2020

auseika commented Apr 14, 2020

sadikyalcin commented Jan 28, 2021

mehthabux commented Mar 11, 2021

mezalejandro commented Mar 4, 2024