Skip to content

Commit

Permalink
passing headers to setDataSource when network video
Browse files Browse the repository at this point in the history
  • Loading branch information
emrahdk committed Jun 9, 2018
1 parent f340025 commit 49cd5b6
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,7 @@ public void setSrc(final String uriString, final String type, final boolean isNe
headers.putAll(toStringMap(mRequestHeaders));
}

setDataSource(uriString);
setDataSource(mThemedReactContext, parsedUrl, headers);
} else if (isAsset) {
if (uriString.startsWith("content://")) {
Uri parsedUrl = Uri.parse(uriString);
Expand Down

1 comment on commit 49cd5b6

@cobarx
Copy link
Contributor

@cobarx cobarx commented on 49cd5b6 Jun 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked at the commit log and this is how it used to work. But in #537 it was changed due to that causing a crash.

I'll have to test this and see if I can repro it and see if there's a way to do it this way and not have the problem. If you can do some investigation as well that would be great.

Please sign in to comment.