Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor changes (code refactoring) #17

Closed
wants to merge 12 commits into from

Conversation

Lazyt3ch
Copy link
Contributor

@Lazyt3ch Lazyt3ch commented Jan 9, 2023

Hello,

I've made some minor changes to two functions in the utility.ts script to make the code a little bit more compact. Hopefully, I didn't break anything.

Regards,
Rashid

P.S. I partially refactored code in the index.ts script to make it a little bit more DRY.

@TheTechsTech
Copy link
Owner

A few things are breaking, look at GitHub Actions CI report 89fb4ba

Under Node 12 and 14 as of now, this could be related to other package node-sys being upgrade, looking at other PR. Just don't have time to further investigate.

@Lazyt3ch
Copy link
Contributor Author

Lazyt3ch commented Jan 10, 2023

I've reverted my first commit, and now the package-lock.json file is as it was before I made any changes to the project. Sorry for causing the trouble.

It looks like I accidentally "closed" the PR; unfortunately, I don't know to "unclose" it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants