Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Candidate 3v3 Coral Islands ZH v1] Some Oil Derricks are rotated at random, without symmetry #715

Closed
xezon opened this issue May 9, 2024 · 5 comments · Fixed by #791
Closed

[Candidate 3v3 Coral Islands ZH v1] Some Oil Derricks are rotated at random, without symmetry #715

xezon opened this issue May 9, 2024 · 5 comments · Fixed by #791
Labels
design Design problem

Comments

@xezon
Copy link
Collaborator

xezon commented May 9, 2024 •
edited
Loading

Observed behavior

Some Oil Derricks are rotated at random, without symmetry.

Expected behavior

Oil Derricks have symmetrical rotations, or rotations that put their flag at a high visibility.

Screenshots

Some samples, not complete.

shot_20240509_091942_6

shot_20240509_091948_7

shot_20240509_091957_8

shot_20240509_092001_9
@xezon xezon added the design Design problem label May 9, 2024
@NoMerciBKK
Copy link
Collaborator

NoMerciBKK commented May 10, 2024 •
edited
Loading

updated outer ring, inner ring not in terms of design

@xezon
Copy link
Collaborator Author

xezon commented May 11, 2024

Outer Oil Derricks are now rotated like so:

shot_20240511_074736_1

May I suggest to rotate them 45 degrees counter clockwise? Then their flag will be no longer in the shade.

Inner ring Oil Derricks are still rotated without a system.

@xezon xezon mentioned this issue May 11, 2024
Merged
xezon added a commit that referenced this issue May 11, 2024
@xezon
Fixes #713, #714, #716, addresses #715, #717 in map candidate Coral I…
4432cfa 
…slands ZH v1
xezon added a commit that referenced this issue May 11, 2024
@xezon
Fixes #713, #714, #716, addresses #715, #717 in map candidate Coral I…
c781f8d 
…slands ZH v1
@xezon
Copy link
Collaborator Author

xezon commented May 11, 2024

One Derrick was not rotated. Otherwise looks good.

shot_20240511_143606_2

xezon added a commit that referenced this issue May 11, 2024
@xezon
Addresses #715 in map candidate 3v3 Coral Islands ZH v1
cecd915
@xezon xezon mentioned this issue May 11, 2024
Merged
xezon added a commit that referenced this issue May 11, 2024
@xezon
Addresses #715 in map candidate 3v3 Coral Islands ZH v1
51f33e3
@xezon
Copy link
Collaborator Author

xezon commented May 22, 2024

Not fixed in new version.

@NoMerciBKK
Copy link
Collaborator

i think i mixed up some versions gonna have a look a bit later sry for the trouble

xezon added a commit that referenced this issue May 30, 2024
@xezon
Fixes #715, #717 in map candidate 3v3 Coral Islands ZH v1
36c9cb4
@xezon xezon mentioned this issue May 30, 2024
Merged
xezon added a commit that referenced this issue May 30, 2024
@xezon
Fixes #715, #717 in map candidate 3v3 Coral Islands ZH v1
f1b064d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
design Design problem
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Map update 20 TheSuperHackers/GeneralsRankedMaps
2 participants
@xezon @NoMerciBKK