Add named arguments to various Node apis
#89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spocke
approved these changes
Feb 1, 2022
| external insertBefore: (T.t, Dom.node_like<'a>, Dom.node_like<'b>) => Dom.node_like<'a> = "insertBefore" | ||
| external insertBefore: (T.t, ~new: Dom.node_like<'a>, ~before: Dom.node_like<'b>) => Dom.node_like<'a> = "insertBefore" | ||
| @send | ||
| external insertAtEnd: (T.t, ~new: Dom.node_like<'a>, @as(json`null`) _) => Dom.node_like<'a> = "insertBefore" |
There was a problem hiding this comment.
Weird didn't know you could do that seems like the same thing as appendChild.
There was a problem hiding this comment.
Yeah I didn't know this existed either, until I was reading the specs while working on the branch. Maybe it doesn't make sense to have both bindings but who knows, maybe some developers prefer to use parent.insertBefore(child, null) 🤷♂️
TheSpyder
force-pushed
the
named_arguments
branch
from
fc072bf to
a4852a5
Compare
Add `Node.insertAtEnd` binding Deprecate `Node.isSameNode` Fixes #49
TheSpyder
force-pushed
the
named_arguments
branch
from
a4852a5 to
ec971c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node.insertAtEndbindingNode.isSameNodeFixes #49
I'm not sure if more are required, I think these are the only ones that tripped us up when we migrated last year. We should verify this before merging.
I didn't change
isEqualNodebecause the order doesn't matter.