Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: HtmlFormControlsCollection and related elements #73

Merged
merged 4 commits into from
Jan 13, 2022
Merged

feat: HtmlFormControlsCollection and related elements #73

merged 4 commits into from
Jan 13, 2022

Conversation

illusionalsagacity
Copy link
Contributor

@illusionalsagacity illusionalsagacity commented Dec 27, 2021 •
edited
Loading

resolves #72, #55

  • testing
  • changeset
  • resolve approach for casting elements
  • duplicated code for element validation?
  • selection range code duplication?

@TheSpyder TheSpyder linked an issue Dec 27, 2021 that may be closed by this pull request
Add bindings for html textarea #55
Closed
spocke
spocke requested changes Dec 27, 2021
View reviewed changes
@illusionalsagacity illusionalsagacity force-pushed the html-form-controls-collection branch from ecd610f to 64244a5 Compare December 27, 2021 19:24
TheSpyder
TheSpyder reviewed Dec 27, 2021
View reviewed changes
Copy link
Owner

@TheSpyder TheSpyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I started my review yesterday and forgot to submit it - apologies if some of my comments double up on things @spocke said 😂

@TheSpyder
Copy link
Owner

The original PR had a test file - is your plan to port that into this PR as well?

@illusionalsagacity
Copy link
Contributor Author

The original PR had a test file - is your plan to port that into this PR as well?

yup, gotta run it in the browser

@illusionalsagacity illusionalsagacity mentioned this pull request Dec 28, 2021
Open
@illusionalsagacity illusionalsagacity force-pushed the html-form-controls-collection branch 4 times, most recently from 6e7c811 to abcf803 Compare December 28, 2021 03:25
@illusionalsagacity illusionalsagacity force-pushed the html-form-controls-collection branch from 274b072 to 25147fa Compare December 28, 2021 22:33
@illusionalsagacity illusionalsagacity marked this pull request as ready for review December 28, 2021 22:38
TheSpyder
TheSpyder reviewed Jan 3, 2022
View reviewed changes
src/Webapi/Dom/Webapi__Dom__HtmlFormControlsCollection.resi
| Select(Dom.htmlSelectElement)
| TextArea(Dom.htmlTextAreaElement)

let namedItem: (t, string) => option<t_namedItem>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not used to seeing interface files in this project but I guess it makes sense for what this file is doing 😅

@TheSpyder TheSpyder requested a review from spocke January 3, 2022 11:38
@TheSpyder
Copy link
Owner

@spocke do you still need changes or can I merge this?

@TheSpyder TheSpyder merged commit 566b6a4 into TheSpyder:main Jan 13, 2022
@illusionalsagacity illusionalsagacity deleted the html-form-controls-collection branch January 13, 2022 02:36
@TheSpyder
Copy link
Owner

published as 0.4.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheSpyder TheSpyder TheSpyder approved these changes

@spocke spocke spocke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

adding HtmlFormControlsCollection Add bindings for html textarea
3 participants
@illusionalsagacity @TheSpyder @spocke