Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Webapi.Canvas.toBlob & Webapi.Canvas.toDataUrl methods #111

Merged
merged 1 commit into from
Nov 3, 2022

Conversation

MoOx
Copy link
Contributor

@MoOx MoOx commented Sep 11, 2022

(with alternatives for options)

Closes #109

Copy link
Owner

@TheSpyder TheSpyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "everything included" methods are a bit wordy but I can't come up with anything better 😂

Sorry it took so long to get to this!

@TheSpyder TheSpyder merged commit c2ac274 into TheSpyder:main Nov 3, 2022
TheSpyder added a commit that referenced this pull request Nov 3, 2022
@TheSpyder
Copy link
Owner

The module or file Blob can't be found

I really need to add CI to this project to check when PRs haven't been compiled before I merge them 😂

@TheSpyder
Copy link
Owner

Published as 0.7.0

MoOx added a commit to MoOx/rescript-webapi that referenced this pull request Nov 5, 2022
Following TheSpyder#111 fail :)
@MoOx MoOx mentioned this pull request Nov 5, 2022
@alex35mil
Copy link
Contributor

Why does toDataUrl (and similar methods) return unit instead of string?

@TheSpyder
Copy link
Owner

Ah. I only confirmed the toBlob signature in the original PR, I didn't check both. oops.

It's an easy fix, or would you like to make the PR for it?

@alex35mil
Copy link
Contributor

@TheSpyder I'm afk for a week. I can push the fix when I'm back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HTML canvas element toBlob method is missing
3 participants