Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new binding to Webapi.FormData to create it from form elements. #108

Merged
merged 1 commit into from
Nov 3, 2022
Merged

Add new binding to Webapi.FormData to create it from form elements. #108

merged 1 commit into from
Nov 3, 2022

Conversation

mvaled
Copy link
Contributor

@mvaled mvaled commented Sep 8, 2022

No description provided.

TheSpyder
TheSpyder requested changes Oct 14, 2022
View reviewed changes
Copy link
Owner

@TheSpyder TheSpyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Sorry it took so long to get to.

@mvaled mvaled force-pushed the add-binding-FormData-fromForm branch from 61ce79b to 30d8635 Compare October 15, 2022 06:28
@mvaled
Copy link
Contributor Author

mvaled commented Oct 21, 2022

@TheSpyder I've the requested changes.

@TheSpyder TheSpyder merged commit e016366 into TheSpyder:main Nov 3, 2022
@TheSpyder
Copy link
Owner

Ah, I forgot to actually compile before I merged. FormData already depends on HtmlFormElement.

FAILED: dependency cycle: src/Webapi/Dom/Webapi__Dom__HtmlFormElement.cmj -> src/Webapi/Webapi__FormData.cmj -> src/Webapi/Dom/Webapi__Dom__HtmlFormElement.cmj.

hmmmmmm that's a tricky one.

@TheSpyder
Copy link
Owner

The name is a bit weird but this function already exists:

https://github.com/tinymce/rescript-webapi/blob/9f616918907ea67b29a4174fd851be0caea8e617/src/Webapi/Dom/Webapi__Dom__HtmlFormElement.res#L39

I'll revert this for now, and add a note to FormData explaining how to make one from a form element. Maybe we can move the function to FormData in v2.

TheSpyder added a commit that referenced this pull request Nov 4, 2022
@TheSpyder
Reverted #108 due to a dependency cycle, leaving a comment about wher…
981f579 
…e to find the other method
@TheSpyder
Copy link
Owner

Published as 0.7.0

@TheSpyder TheSpyder mentioned this pull request Nov 4, 2022
Open
@mvaled mvaled deleted the add-binding-FormData-fromForm branch September 6, 2023 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheSpyder TheSpyder TheSpyder approved these changes

@spocke spocke Awaiting requested review from spocke spocke is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mvaled @TheSpyder