Add encoding as an option to various methods (sikanhe/reason-nodejs#53)

TheSpyder · Sep 13, 2021 · d0a82e7 · d0a82e7
1 parent de6aaa4
commit d0a82e7
Showing 1 changed file with 9 additions and 11 deletions.
diff --git a/src/Fs.res b/src/Fs.res
@@ -189,14 +189,14 @@ type fd = private int
 
 type writeFileOptions
 @obj
-external writeFileOptions: (~mode: int=?, ~flag: string=?, unit) => writeFileOptions = ""
+external writeFileOptions: (~mode: int=?, ~flag: string=?, ~encoding: string=?, unit) => writeFileOptions = ""
 
 type appendFileOptions
 @obj
-external appendFileOptions: (~mode: int=?, ~flag: Flag.t=?, unit) => appendFileOptions = ""
+external appendFileOptions: (~mode: int=?, ~flag: Flag.t=?, ~encoding: string=?, unit) => appendFileOptions = ""
 
 type readFileOptions
-@obj external readFileOptions: (~flag: Flag.t=?, unit) => readFileOptions = ""
+@obj external readFileOptions: (~flag: Flag.t=?, ~encoding: string=?, unit) => readFileOptions = ""
 
 /**
  * `readdirSync(path)`
@@ -239,14 +239,10 @@ external openSyncWith: (string, ~flag: Flag.t=?, ~mode: int=?) => fd = "openSync
 external readFileSync: (string, ~options: readFileOptions=?, unit) => Buffer.t = "readFileSync"
 @module("fs") external existsSync: string => bool = "existsSync"
 
-type writeFileSyncOptions
-@obj
-external writeFileSyncOptions: (~mode: int=?, ~flag: Flag.t=?, unit) => writeFileSyncOptions = ""
-
 @val @module("fs")
 external writeFileSync: (string, Buffer.t) => unit = "writeFileSync"
 @val @module("fs")
-external writeFileSyncWith: (string, Buffer.t, writeFileSyncOptions) => unit = "writeFileSync"
+external writeFileSyncWith: (string, Buffer.t, writeFileOptions) => unit = "writeFileSync"
 
 module FileHandle = {
   type t
@@ -300,7 +296,7 @@ module FileHandle = {
 
   type writeFileOptions
   @obj
-  external writeFileOptions: (~mode: int=?, ~flag: Flag.t=?, unit) => writeFileOptions = ""
+  external writeFileOptions: (~mode: int=?, ~flag: Flag.t=?, ~encoding: string=?, unit) => writeFileOptions = ""
 
   @send
   external writeFile: (t, Buffer.t) => Js.Promise.t<unit> = "writeFile"
@@ -373,10 +369,10 @@ external mkdirSync: string => unit = "mkdirSync"
 external mkdirSyncWith: (string, mkdirOptions) => unit = "mkdirSync"
 
 type mkdtempOptions
-@obj external mdktempOptions: unit => mkdtempOptions = ""
+@obj external mdktempOptions: (~encoding: string=?, unit) => mkdtempOptions = ""
 
 @module("fs") @scope("promises")
-external mkdtemp: (string, mkdtempOptions) => Js.Promise.t<string> = "mkddtemp"
+external mkdtemp: (string) => Js.Promise.t<string> = "mkddtemp"
 
 @module("fs") @scope("promises")
 external mkdtempWith: (string, mkdtempOptions) => Js.Promise.t<string> = "mkddtemp"
@@ -447,6 +443,7 @@ type createReadStreamOptions
 @obj
 external createReadStreamOptions: (
   ~flags: string=?,
+  ~encoding: string=?,
   ~fd: fd=?,
   ~mode: int=?,
   ~autoClose: bool=?,
@@ -467,6 +464,7 @@ type createWriteStreamOptions
 @obj
 external createWriteStreamOptions: (
   ~flags: string=?,
+  ~encoding: string=?,
   ~fd: fd=?,
   ~mode: int=?,
   ~autoClose: bool=?,