Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xName missing in CCSale, CCAuth, CCCapture, CCCredit, transactions #90

Closed
mfried40 opened this issue May 30, 2024 · 1 comment · Fixed by #91
Closed

xName missing in CCSale, CCAuth, CCCapture, CCCredit, transactions #90

mfried40 opened this issue May 30, 2024 · 1 comment · Fixed by #91

Comments

@mfried40
Copy link
Contributor

Describe the bug
When processing a CCSale transaction the xName property is missing in the request

To Reproduce

Cardknox cardknox = new Cardknox(new CardknoxReqest(<Key>, <SoftwareName>, <Version>));
CCSale ccSale = new CCSale();
ccSale.Amount = 1.00m;
//add the name on card
ccSale.Name = "Name On Card";
ccSale.CardNum = "4444333322221111";
ccSale.Exp = "1234";
CardknoxResponse response = cardknox.CCSale(ccSale);
//now check the transaction in cardknox portal the name on card will be missing

Expected behavior
Name should be included in the request

Additional context
Code to add the name to the request is missing here

// The next many fields are optional and so there will be a lot of if statements here
// Optional, but recommended
if (!IsNullOrWhiteSpace(_sale.Street))
    _values.Add("xStreet", _sale.Street);

if (!IsNullOrWhiteSpace(_sale.Zip))
    _values.Add("xZip", _sale.Zip);

I'll add the required code, test it and make a pull request

@mfried40 mfried40 changed the title xName missing in CCSale transactions xName missing in CCSale, CCAuth, CCCapture, CCCredit, transactions May 30, 2024
@mfried40
Copy link
Contributor Author

I noticed now that it's also missing in CCAuth, CCCapture, and CCCredit transactions

mfried40 added a commit to mfried40/Cardknox-API-Wrapper that referenced this issue May 30, 2024
@ahwm ahwm closed this as completed in #91 May 30, 2024
ahwm added a commit that referenced this issue May 30, 2024
Added missing code for xName in CCSale, CCAuth, CCCapture, and CCCredit. fixes #90
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant