This repository has been archived by the owner on Oct 12, 2023. It is now read-only.
Support registered processes as ancestors #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulissesalmeida
approved these changes
Jul 2, 2018
The ancestry tree fetched from the current process dictionary may
contain some registered process names (atoms), rather than solely
PIDs. In that case New Relixir would crash with this error:
** (ArgumentError) argument error
:erlang.process_info(:named_ancestor, :dictionary)
(elixir) lib/process.ex:646: Process.info/2
lib/new_relixir/current_transaction.ex:51: NewRelixir.CurrentTransaction.extract_transaction/1
(elixir) lib/enum.ex:2914: Enum.find_value_list/3
lib/new_relixir/current_transaction.ex:44: NewRelixir.CurrentTransaction.search_on_ancestors/0
lib/new_relixir/current_transaction.ex:21: NewRelixir.CurrentTransaction.get/0
(elixir) lib/task/supervised.ex:88: Task.Supervised.do_apply/2
(elixir) lib/task/supervised.ex:38: Task.Supervised.reply/5
(stdlib) proc_lib.erl:247: :proc_lib.init_p_do_apply/3
Function: &NewRelixir.CurrentTransaction.get/0
Args: []
britto
force-pushed
the
support-registered-processes-as-ancestors
branch
from
148f42a to
bac7dfc
Compare
coburncoburn
approved these changes
Jul 3, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ancestry tree fetched from the current process dictionary may contain some registered process names (atoms), rather than just PIDs. In that case New Relixir would crash with this error:
Fixes #57.