-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mason #24
Comments
Created PR: mason-org/mason-registry#3084. You can assign issue to me if you would like. |
PR has been merged! I think we should close the issue. Mason now gets the binary from Cargo, which I think is pushed via gh actions? |
Unfortunately GH Actions aren't pushing to crates.io yet, @ThePrimeagen has been manually. I'd like to get that setup but it requires a GH Actions secret for Primes crates.io account |
If we want to the latest binary to ship to Mason, we would need to update it to use the GitHub releases. Not an issue, but would need another PR to Mason. Let me know how you want to proceed. |
I'd like to get CI pushing to crates.io, but let's wait to hear from Prime on that. I don't think it matters for the next month since the v0.1.0 release is mostly fully featured (if i recall correctly) and changes since then haven't been major. |
I tried installing the lsp with Mason but got a bunch of This is the install log:
Is this a problem on my end or is this something that needs to be fixed here? |
What version of rust/cargo are you using?
You could be using an older/newer version that marks those as unstable.
…On Mon, Nov 13, 2023 at 7:16 AM, Maik Schmaddebeck ***@***.***(mailto:On Mon, Nov 13, 2023 at 7:16 AM, Maik Schmaddebeck <<a href=)> wrote:
I tried installing the lsp with Mason but got a bunch of use of unstable library feature 'once_cell' errors.
This is the install log:
Installing crate ***@***.***…
Updating crates.io index
Installing htmx-lsp v0.1.0
... bunch of compiling here ...
Compiling htmx-lsp-server v0.1.0
error[E0658]: use of unstable library feature 'once_cell'
--> /root/.cargo/registry/src/github.com-1ecc6299db9ec823/htmx-lsp-server-0.1.0/src/htmx/mod.rs:4:48
|
4 | use std::{collections::HashMap, path::PathBuf, sync::OnceLock};
| ^^^^^^^^^^^^^^
|
= note: see issue #74465 <rust-lang/rust#74465> for more information
Is this a problem on my end or is this something that needs to be fixed here?
—
Reply to this email directly, [view it on GitHub](#24 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/ABGY5FSGCVID2DDBNYEZ3WTYEIFTVAVCNFSM6AAAAAA535GE6GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBYGA2TIMZYG4).
You are receiving this because you commented.Message ID: ***@***.***>
|
Well, that fixed my problem already. I haven't used Rust in a while and the versions where over a year old apparently. rustup 1.25.1 (bb60b1e89 2022-07-12) I updated them to the newest versions and now the htmx lsp installed without a problem 👍 |
We now have
cargo install htmx-lsp
now we just need mason linking.as of now, i am not able to do much until Nov 17th+, so i will not be looking much at this until then
The text was updated successfully, but these errors were encountered: