Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mason #24

Closed
ThePrimeagen opened this issue Oct 11, 2023 · 8 comments
Closed

Mason #24

ThePrimeagen opened this issue Oct 11, 2023 · 8 comments

Comments

@ThePrimeagen
Copy link
Owner

We now have cargo install htmx-lsp now we just need mason linking.

as of now, i am not able to do much until Nov 17th+, so i will not be looking much at this until then

@OZoneGuy
Copy link
Contributor

OZoneGuy commented Oct 15, 2023

Created PR: mason-org/mason-registry#3084.

You can assign issue to me if you would like.

@OZoneGuy
Copy link
Contributor

PR has been merged! I think we should close the issue. Mason now gets the binary from Cargo, which I think is pushed via gh actions?

@MNThomson
Copy link
Collaborator

Unfortunately GH Actions aren't pushing to crates.io yet, @ThePrimeagen has been manually. I'd like to get that setup but it requires a GH Actions secret for Primes crates.io account

@OZoneGuy
Copy link
Contributor

OZoneGuy commented Oct 24, 2023

If we want to the latest binary to ship to Mason, we would need to update it to use the GitHub releases. Not an issue, but would need another PR to Mason. Let me know how you want to proceed.

@MNThomson
Copy link
Collaborator

I'd like to get CI pushing to crates.io, but let's wait to hear from Prime on that. I don't think it matters for the next month since the v0.1.0 release is mostly fully featured (if i recall correctly) and changes since then haven't been major.

@maiksch
Copy link

maiksch commented Nov 13, 2023

I tried installing the lsp with Mason but got a bunch of use of unstable library feature 'once_cell' errors.

This is the install log:

Installing crate htmx-lsp@0.1.0…
    Updating crates.io index
  Installing htmx-lsp v0.1.0

... bunch of compiling here ...

  Compiling htmx-lsp-server v0.1.0
        error[E0658]: use of unstable library feature 'once_cell'
         --> /root/.cargo/registry/src/github.com-1ecc6299db9ec823/htmx-lsp-server-0.1.0/src/htmx/mod.rs:4:48
          |
        4 | use std::{collections::HashMap, path::PathBuf, sync::OnceLock};
          |                                                ^^^^^^^^^^^^^^
          |
          = note: see issue #74465 <https://github.com/rust-lang/rust/issues/74465> for more information

Is this a problem on my end or is this something that needs to be fixed here?

@OZoneGuy
Copy link
Contributor

OZoneGuy commented Nov 13, 2023 via email

@maiksch
Copy link

maiksch commented Nov 13, 2023

What version of rust/cargo are you using? You could be using an older/newer version that marks those as unstable.

Well, that fixed my problem already. I haven't used Rust in a while and the versions where over a year old apparently.

rustup 1.25.1 (bb60b1e89 2022-07-12)
rustc 1.65.0 (897e37553 2022-11-02)
cargo 1.65.0 (4bc8f24d3 2022-10-20)

I updated them to the newest versions and now the htmx lsp installed without a problem 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants