Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ibmi, build_release, and maven workflows #127

Merged
merged 4 commits into from
Jul 22, 2024
Merged

Update ibmi, build_release, and maven workflows #127

merged 4 commits into from
Jul 22, 2024

Conversation

SanjulaGanepola
Copy link
Collaborator

@SanjulaGanepola SanjulaGanepola commented Jul 18, 2024 •
edited
Loading

Changes

  • Use Node 20
  • Update action dependency versions
  • Extract out build libraries (MZNCI, MANZANBLD, MANZAN) into env vars
  • Simplify release workflow using@ibm/ibmi-ci
  • Change release trigger to be on GitHub releases instead of tag
  • For consistency/readability, switched to env context syntax (for example ${{ env.jar_file }}) when referencing env vars

@SanjulaGanepola
use Node 18, extract out ci_build_lib env var
0546d45 
Signed-off-by: Sanjula Ganepola <Sanjula.Ganepola@ibm.com>
@SanjulaGanepola
use Node 18, use @ibm/ibmi-ci, update secrets, change to release trigger
eccbb31 
Signed-off-by: Sanjula Ganepola <Sanjula.Ganepola@ibm.com>
@SanjulaGanepola
switch to use env context syntax
b523180 
Signed-off-by: Sanjula Ganepola <Sanjula.Ganepola@ibm.com>
@SanjulaGanepola
bump nodejs 20 and update action versions
b6c4cb1 
Signed-off-by: Sanjula Ganepola <Sanjula.Ganepola@ibm.com>
@SanjulaGanepola SanjulaGanepola changed the title Update build and release workflows Update ibmi, build_release, and maven workflows Jul 18, 2024
@SanjulaGanepola
Copy link
Collaborator Author

@ThePrez Can I go ahead with merging this to see if the workflows are all good?

@ThePrez
Copy link
Owner

ThePrez commented Jul 22, 2024

@ThePrez Can I go ahead with merging this to see if the workflows are all good?

Rock on!

@SanjulaGanepola SanjulaGanepola merged commit 1678f2f into main Jul 22, 2024
1 check passed
@SanjulaGanepola SanjulaGanepola deleted the refactor/build-and-release-workflows branch July 22, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThePrez ThePrez Awaiting requested review from ThePrez

@jonnyz32 jonnyz32 Awaiting requested review from jonnyz32

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SanjulaGanepola @ThePrez