Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README.md updated dependency instructions #43

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

nickcat325
Copy link

When running sudo pip install -r requirements.txt normally, I get the error externally-managed-environment. pip recommends using pacman. Adding --break-system-packages works too but mixing pacman and pip packages is risky.

When running sudo pip install -r requirements.txt normally, I get the error externally-managed-environment. pip recommends using pacman. Adding --break-system-packages works too but mixing pacman and pip packages is risky.
@PierreCsn
Copy link

you need to use sudo pacman -S scapy that s it

@0xBA5E64
Copy link

0xBA5E64 commented May 3, 2024

You can alternatively install the python dependencies in a venv as such:

$ python3 -m venv .venv
$ source ./.venv/bin/activate
$ pip install -r requirements.txt

Which, may be a preferable solution, since it'll work on any system, not just Arch. It's usually not a good idea to install python dependencies globally either-way, if you can avoid it.

@nickcat325
Copy link
Author

True, I know venv also works. Maybe I should add all of this info, as an optional expandable section.

@0xBA5E64
Copy link

0xBA5E64 commented May 3, 2024

I think it could be argued setting up PPPwn through a venv should be part of the default setup process for PPPwn, since that might help address similar issues to this on other systems as well with an externally managed Python environment.

@nickcat325 nickcat325 changed the title Arch Linux install requirements README.md updated dependency instructions May 3, 2024
@nickcat325 nickcat325 marked this pull request as draft May 3, 2024 14:56
@naongatjxe
Copy link

On Mac pip does work, you use pip3

@nickcat325 nickcat325 marked this pull request as ready for review May 3, 2024 19:51
@Fastball2880
Copy link

Fastball2880 commented May 3, 2024

You can alternatively install the python dependencies in a venv as such:

$ python3 -m venv .venv
$ source ./.venv/bin/activate
$ pip install -r requirements.txt

Which, may be a preferable solution, since it'll work on any system, not just Arch. It's usually not a good idea to install python dependencies globally either-way, if you can avoid it.

I agree with this. As often I'm concerned about conflicts with packages between Linux and Python, as seen in my PR.

This type of installation could be added as an second option or an alternative for Linux users.

@salehif
Copy link

salehif commented May 5, 2024

same on ubuntu
alternative way is to install using this command, since requirements.txt include scapy only

$ apt install python3-scapy

@nickcat325
Copy link
Author

$ apt install python3-scapy

This is already in the PR. Also apt requires root permisions to install

$ sudo apt install

or

$ su
# apt install

@Fastball2880
Copy link

Fastball2880 commented May 5, 2024

```shell
$ apt install python3-scapy

This is already in the PR. Also apt requires root permisions to install

$ sudo apt install

or

$ su
# apt install

I don't recommend running this in root or su! This is a bad practice in security unless you really need it

Copy link

@Fastball2880 Fastball2880 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I don't think an instructions for each district won't be needed as it will be the same on every other package managers, as long they know what they're doing.

Consider Void Linux, where it uses a different package manager.

@Fastball2880
Copy link

It's better to make the commands using apt, assuming that they need to install it. Besides, probably the general population will use Debian-based distributions either way.

@seif19000
Copy link

seif19000 commented May 6, 2024

can you add to requirments in readme that the USB adapter of ethernet needs to be 3.0 otherwise if it's 2.0 you'll get stuck in "waiting for PADR"

@Fastball2880
Copy link

can you add to requirments in readme that the USB adapter of ethernet need to be 3.0 otherwise if it's 2.0 you'll get stuck in "waiting for PADR"

Did it hang for an hour when using a USB 2.0?

@seif19000
Copy link

can you add to requirments in readme that the USB adapter of ethernet need to be 3.0 otherwise if it's 2.0 you'll get stuck in "waiting for PADR"

Did it hang for an hour when using a USB 2.0?

It shows ip failure everytime in stage 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants