Improve support for AppVeyor CI #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xolox
added a commit
to paylogic/pip-accel
that referenced
this pull request
Oct 31, 2015
Until my pull request against coveralls-python is merged [1] or an update from Coveralls is posted on an issue I replied to [2] I guess this is my last change with regards to Windows support [3] (unless bug reports come in - let's hope I didn't just jinx that :-). [1] TheKevJames/coveralls-python#97 [2] lemurheavy/coveralls-public#613 [3] #61
coagulant
added a commit
that referenced
this pull request
Nov 6, 2015
Improve support for AppVeyor CI
|
Thnx, could you please update README too? |
|
Hi Ilya and thanks for merging my pull request! What would you like me to add to the readme? From my understanding Travis CI and Circle CI are "special" in the sense that a repo token isn't required (while this is required for AppVeyor just like it is for other CI environments) but apart from that the instructions under the Usage (another CI) section seem to be sufficient already. Or would you like the readme to explicitly/specifically mention that AppVeyor is supported? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently I added Windows support, AppVeyor CI tests and coverage collection on Windows to a project of mine (see paylogic/pip-accel#61). In the process I found that support for AppVeyor in coveralls-python was a bit tricky to get right.
The
$CI_BRANCHenvironment variable isn't available on AppVeyor and thegit rev-parse --abbrev-ref HEADfallback in coveralls-python incorrectly resulted inHEADwhich meant my coverage reports on Coveralls.io referenced the branch nameHEADinstead of the expected valuemaster(kind of confusing becauseHEADisn't a branch AFAIK :-).During experimentation I worked around this by creating a wrapper for the
coverallscommand that would set$CI_BRANCHbased on$APPVEYOR_REPO_BRANCHwhich resulted in correct behavior. However this implies that every user of coveralls-python would need to do this, so I decided to fork and extend coveralls-python instead, hopefully saving future users some time and frustration.My additions follow the "examples" given by the existing Travis and Circle CI support, this is how I decided what the values of
service_job_idandservice_pull_requestshould be (cross-referencing with the documented environment variables for AppVeyor).I added a test as well that passes in all Python environments I am able to test (I don't have PyPy and certain Python 3 versions installed).