Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This is an implementation proposal that should fix #56. The code is compiling but I haven't tested it (I don't know how to include the built project into a fresh TheHive or Cortex build).
Sorry for having removed the for comprehension structure used to generate the xpackClient but I haven't found a proper solution to keep it with multiple independent options so I got back to a more classical way to handle to client setting.
This pull request adds the following features:
Here is a sample configuration that should be supported from now on:
I hope this will fit your expectations. Don't hesitate to point me some improvements to be made if necessary.