Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Case template endpoint #375

Merged
merged 6 commits into from
Jan 15, 2025
Merged

Case template endpoint #375

merged 6 commits into from
Jan 15, 2025

Conversation

Anko59
Copy link
Contributor

@Anko59 Anko59 commented Dec 27, 2024

No description provided.

@Anko59 Anko59 force-pushed the 374-case-templates-endpoint branch 3 times, most recently from fb6b178 to 130d288 Compare December 27, 2024 11:25
@Anko59 Anko59 changed the title Case template endpoint [WIP] Case template endpoint Dec 27, 2024
@Anko59
Copy link
Contributor Author

Anko59 commented Dec 27, 2024

I am struggling with signing the commits given the multiple github accounts and ssh keys I have on this laptop. Will try again later.

@Anko59 Anko59 force-pushed the 374-case-templates-endpoint branch from 130d288 to 9d7c45e Compare December 27, 2024 13:03
@Anko59 Anko59 changed the title [WIP] Case template endpoint Case template endpoint Dec 27, 2024
@Anko59
Copy link
Contributor Author

Anko59 commented Dec 27, 2024

Ready for review

@codecov Codecov
Copy link

codecov bot commented Dec 27, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.23%. Comparing base (570066e) to head (55fdf07).
Report is 19 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #375      +/-   ##
==========================================
+ Coverage   92.94%   93.23%   +0.28%     
==========================================
  Files          27       28       +1     
  Lines         751      783      +32     
==========================================
+ Hits          698      730      +32     
  Misses         53       53

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Anko59
Anko59 commented Dec 27, 2024
View reviewed changes
.pre-commit-config.yaml
stages: [pre-push]
Copy link
Contributor Author

@Anko59 Anko59 Dec 27, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pre-commit run --all-files triggers hook id 'ci-checks' uses deprecated stage names (push) which will be removed in a future version. run: 'pre-commit migrate-config' to automatically fix this.
running pre-commit migrate-config makes this modification to the pre-commit yaml

@Kamforka Kamforka self-requested a review January 8, 2025 11:47
@Kamforka Kamforka added category:enhancement 2.x changelog:added changelog label for new features. labels Jan 8, 2025
@Kamforka Kamforka added this to the 2.0.0b8 milestone Jan 8, 2025
@Kamforka
Copy link
Collaborator

Kamforka commented Jan 8, 2025

Hi @Anko59 , thank you very much for your contribution!
I'll review it as I find the time!

Kamforka
Kamforka reviewed Jan 12, 2025
View reviewed changes
Copy link
Collaborator

@Kamforka Kamforka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left a couple of suggestions please check them out.
Altogether a really nice addition, thank you for that!

tests/conftest.py Outdated Show resolved Hide resolved
tests/conftest.py Outdated Show resolved Hide resolved
tests/conftest.py Outdated Show resolved Hide resolved
tests/conftest.py Outdated Show resolved Hide resolved
tests/test_case_template_endpoint.py Outdated Show resolved Hide resolved
@Kamforka Kamforka linked an issue Jan 12, 2025 that may be closed by this pull request
Endpoint for Case templates #374
Closed
@Anko59 Anko59 requested a review from Kamforka January 14, 2025 15:01
@Anko59 @Kamforka
Update thehive4py/endpoints/case_template.py
55fdf07 
Co-authored-by: Kamforka <antalszabolcs01@gmail.com>
@Kamforka Kamforka merged commit 71fcdf0 into TheHive-Project:main Jan 15, 2025
13 checks passed
@Kamforka
Copy link
Collaborator

Thank you for your contribution @Anko59, great job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kamforka Kamforka Kamforka left review comments

Assignees

@Anko59 Anko59

Labels
2.x category:enhancement changelog:added changelog label for new features.
Projects
None yet
Milestone
2.0.0b8
Development

Successfully merging this pull request may close these issues.

Endpoint for Case templates
2 participants
@Anko59 @Kamforka