Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for 5.0.1 #241

Merged
merged 8 commits into from
Apr 6, 2022
Merged

Update for 5.0.1 #241

merged 8 commits into from
Apr 6, 2022

Conversation

vdebergue
Copy link
Contributor

Main change is the ability to add observables in the alert creation.

In that case, the request needs to use a multipart

.gitignore Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
thehive4py/endpoints/alert.py Outdated Show resolved Hide resolved
thehive4py/types/case.py Outdated Show resolved Hide resolved
@vdebergue vdebergue requested a review from Kamforka March 25, 2022 10:31
Copy link
Collaborator

@Kamforka Kamforka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall! I left some suggestions.
Also I think it would make sense to run the integration tests to verify that everything is working and then proceed with the merge.

tests/test_alert_endpoint.py Show resolved Hide resolved
thehive4py/endpoints/_base.py Show resolved Hide resolved
thehive4py/endpoints/alert.py Outdated Show resolved Hide resolved
@Kamforka Kamforka merged commit b5017b5 into develop Apr 6, 2022
@Kamforka Kamforka deleted the feature/update-5.0.1 branch April 6, 2022 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants