TheHive4: equal signs instead of colons for tags #848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheHive4 does use equal signs instead of colons for tags See issue: TheHive-Project#847
|
Thanks, but probably is better if you check for both (mail: & mail=) in or to keep everything working also in thehive3. |
|
@dadokkio okay thanks. I will try to add both |
Check ist made for "mail:" or "mail=" Same for "mailto"
|
@dadokkio i added an OR condition |
dadokkio
requested review from
jeromeleonard
and removed request for
jeromeleonard
jeromeleonard
approved these changes
Oct 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TheHive4 does use equal signs instead of colons for tags
See issue: #847