Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mode when creating FireHOL ipset directory #158

Merged
merged 1 commit into from
Jan 9, 2018
Merged

Fix mode when creating FireHOL ipset directory #158

merged 1 commit into from
Jan 9, 2018

Conversation

srilumpa
Copy link
Contributor

Hi,

I tried to use the FireHOL analyzer on last version but encountered the following error when executing it:

$ ./analyzers/FireHOLBlocklists/firehol_blocklists.py <<< '{"data":"1.2.3.4", "dataType":"ip", "config":{"blocklistpath": "/tmp/firehol"}}'
  File "./analyzers/FireHOLBlocklists/firehol_blocklists.py", line 30
    os.mkdir(self.path, 0700)
                           ^
SyntaxError: invalid token

This pull request seems to fix it.

$ ./analyzers/FireHOLBlocklists/firehol_blocklists.py <<< '{"data":"1.2.3.4", "dataType":"ip", "config":{"blocklistpath": "/tmp/firehol"}}'
{"success": true, "summary": {"taxonomies": [{"level": "safe", "namespace": "Firehol", "predicate": "Blocklists", "value": "\"0 hit\""}]}, "artifacts": [], "full": {"hits": [], "count": 0}}

Best regards.

Copy link
Contributor

@3c7 3c7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thank you.

@3c7 3c7 added this to the 1.8.0 milestone Dec 29, 2017
@3c7 3c7 merged commit ef05b7e into TheHive-Project:master Jan 9, 2018
@srilumpa srilumpa deleted the FireHOL_fixes branch January 9, 2018 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants