Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CIRCLPassiveSSL_2_0 requires colons or dashes in hashes #229

Closed
syloktools opened this issue Apr 12, 2018 · 2 comments
Closed

CIRCLPassiveSSL_2_0 requires colons or dashes in hashes #229

syloktools opened this issue Apr 12, 2018 · 2 comments
Assignees
@3c7
Labels
category:enhancement Issue is related to an existing feature to improve scope:analyzer Issue is analyzer related
Milestone
1.9.4

Comments

@syloktools
Copy link
Contributor

Request Type

Bug

Description

When using the CIRCLPassiveSSL analyzer it complains that the observable is not in the right format.

image
@3c7
Copy link
Contributor

3c7 commented Apr 13, 2018

Hey @robertnixon2003,

the pypssl module returns an exception if there's no valid json returned by the server. This can be the case, if the certificate hash could not be found, but also if the hash contains colons or dashes.

The error message is not clear to understand, I'll think of some possible distinction there.

@3c7 3c7 added this to the 1.10.0 milestone Apr 13, 2018
@3c7 3c7 self-assigned this Apr 13, 2018
@3c7 3c7 added category:enhancement Issue is related to an existing feature to improve scope:analyzer Issue is analyzer related labels Apr 13, 2018
@3c7 3c7 modified the milestones: 1.10.0, 1.9.4 Apr 13, 2018
@3c7
Copy link
Contributor

3c7 commented Apr 13, 2018

FYI: the return value from the server for the queried hash is Incorrect format of the certificate fingerprint (expected SHA1 in hex format).

3c7 added a commit that referenced this issue Apr 13, 2018
@3c7
Fixes #229: Changed passiveSSL error msg.
298bf48
3c7 added a commit that referenced this issue Apr 13, 2018
@3c7
Fixes #229: Added error msg for hashes with len != 40
1c74ce8
@3c7 3c7 closed this as completed Apr 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@3c7 3c7

Labels
category:enhancement Issue is related to an existing feature to improve scope:analyzer Issue is analyzer related
Projects
None yet
Milestone
1.9.4
Development

No branches or pull requests
2 participants
@3c7 @syloktools