Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove #7

Closed
ashleyhood opened this issue Jul 27, 2016 · 1 comment
Closed

Remove #7

ashleyhood opened this issue Jul 27, 2016 · 1 comment

Comments

@ashleyhood
Copy link
Contributor

There are some composer packages that are not needed if you want to use this as just a library.

I am suggesting to remove /src/TheFox/Console and the following composer packages:

"symfony/console": "~2.5",
"symfony/filesystem": "~2.5",
"liip/process-manager": "~1.0"

Also phpmailer/phpmailer should be moved into require-dev in composer.json

My reason behind this is that I'm using an updated version of the Symfony components and this is causing a conflict.

I'm happy to create a pull request for this but wanted to check that this change would be feasible or even desirable.

I realise that this would be a major change and a lot of code would be removed but I would rather not have an incompatible fork.

@TheFox
Copy link
Owner

TheFox commented Aug 2, 2016

Yeah, sure! Do it. ;) The reason why I added /src/TheFox/Console is because of the Stand-alone server. But this of course is only for testing purposes and not needed by production systems. Maybe I'll make a separate repository for that. PHPMailer is only used in example.php, so move it.

TheFox added a commit that referenced this issue Aug 3, 2016
TheFox added a commit that referenced this issue Aug 3, 2016
TheFox added a commit that referenced this issue Aug 3, 2016
@TheFox TheFox closed this as completed Sep 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants