-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove #7
Comments
Yeah, sure! Do it. ;) The reason why I added |
Closed
TheFox
added a commit
that referenced
this issue
Aug 3, 2016
TheFox
added a commit
that referenced
this issue
Aug 3, 2016
TheFox
added a commit
that referenced
this issue
Aug 3, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There are some composer packages that are not needed if you want to use this as just a library.
I am suggesting to remove
/src/TheFox/Console
and the following composer packages:Also
phpmailer/phpmailer
should be moved into require-dev in composer.jsonMy reason behind this is that I'm using an updated version of the Symfony components and this is causing a conflict.
I'm happy to create a pull request for this but wanted to check that this change would be feasible or even desirable.
I realise that this would be a major change and a lot of code would be removed but I would rather not have an incompatible fork.
The text was updated successfully, but these errors were encountered: