Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[housekeeping] Automated PR to fix formatting errors #754

Merged
merged 1 commit into from
Mar 23, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions GitTrends.Functions/Functions/GenerateGitHubOAuthToken.cs
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,10 @@ namespace GitTrends.Functions
{
class GenerateGitHubOAuthToken
{
readonly static string _clientSecret = Environment.GetEnvironmentVariable("GitTrendsClientSecret") ?? string.Empty;
readonly static string _clientId = Environment.GetEnvironmentVariable("GitTrendsClientId") ?? string.Empty;
static readonly string _clientSecret = Environment.GetEnvironmentVariable("GitTrendsClientSecret") ?? string.Empty;
static readonly string _clientId = Environment.GetEnvironmentVariable("GitTrendsClientId") ?? string.Empty;

readonly static JsonSerializer _serializer = new();
static readonly JsonSerializer _serializer = new();

readonly GitHubAuthService _gitHubAuthService;

Expand Down
4 changes: 2 additions & 2 deletions GitTrends.Functions/Functions/GetAppCenterApiKeys.cs
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ namespace GitTrends.Functions
{
public static class GetAppCenterApiKeys
{
readonly static string _iOS = Environment.GetEnvironmentVariable("AppCenterApiKey_iOS") ?? string.Empty;
readonly static string _android = Environment.GetEnvironmentVariable("AppCenterApiKey_Android") ?? string.Empty;
static readonly string _iOS = Environment.GetEnvironmentVariable("AppCenterApiKey_iOS") ?? string.Empty;
static readonly string _android = Environment.GetEnvironmentVariable("AppCenterApiKey_Android") ?? string.Empty;

[Function(nameof(GetAppCenterApiKeys))]
public static async Task<HttpResponseData> Run([HttpTrigger(AuthorizationLevel.Function, "get")] HttpRequestData req, FunctionContext context)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ namespace GitTrends.Functions
{
public static class GetGitTrendsEnableOrganizationsUri
{
readonly static string _enableOrganizationsUrl = Environment.GetEnvironmentVariable("EnableOrganizationsUrl") ?? string.Empty;
static readonly string _enableOrganizationsUrl = Environment.GetEnvironmentVariable("EnableOrganizationsUrl") ?? string.Empty;

[Function(nameof(GetGitTrendsEnableOrganizationsUri))]
public static async Task<HttpResponseData> Run([HttpTrigger(AuthorizationLevel.Anonymous, "get")] HttpRequestData req, FunctionContext functionContext)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ public static class GetNotificationHubInformation
public static string NotificationHubName { get; } = Environment.GetEnvironmentVariable("NotificationHubName") ?? string.Empty;
public static string NotificationHubName_Debug { get; } = Environment.GetEnvironmentVariable("NotificationHubName_Debug") ?? string.Empty;

readonly static string _notificationHubConnectionString_Debug = Environment.GetEnvironmentVariable("NotificationHubListenConnectionString_Debug") ?? string.Empty;
readonly static string _notificationHubConnectionString = Environment.GetEnvironmentVariable("NotificationHubListenConnectionString") ?? string.Empty;
static readonly string _notificationHubConnectionString_Debug = Environment.GetEnvironmentVariable("NotificationHubListenConnectionString_Debug") ?? string.Empty;
static readonly string _notificationHubConnectionString = Environment.GetEnvironmentVariable("NotificationHubListenConnectionString") ?? string.Empty;

[Function(nameof(GetNotificationHubInformation))]
public static async Task<HttpResponseData> Run([HttpTrigger(AuthorizationLevel.Function, "get")] HttpRequestData req, FunctionContext functionContext)
Expand Down
4 changes: 2 additions & 2 deletions GitTrends.Functions/Functions/GetStreamingManifests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ namespace GitTrends.Functions
{
public static class GetStreamingManifests
{
readonly static string _chartVideoManifestUrl = Environment.GetEnvironmentVariable("ChartVideoManifestUrl") ?? string.Empty;
readonly static string _enableOrganizationsVideoManifestUrl = Environment.GetEnvironmentVariable("EnableOrganizationsVideoManifestUrl") ?? string.Empty;
static readonly string _chartVideoManifestUrl = Environment.GetEnvironmentVariable("ChartVideoManifestUrl") ?? string.Empty;
static readonly string _enableOrganizationsVideoManifestUrl = Environment.GetEnvironmentVariable("EnableOrganizationsVideoManifestUrl") ?? string.Empty;

[Function(nameof(GetStreamingManifests))]
public static async Task<HttpResponseData> Run([HttpTrigger(AuthorizationLevel.Anonymous, "get")] HttpRequestData req, FunctionContext functionContext)
Expand Down
2 changes: 1 addition & 1 deletion GitTrends.Functions/Functions/GetTestToken.cs
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ namespace GitTrends.Functions
{
class GetTestToken
{
readonly static IReadOnlyDictionary<string, string> _testTokenDictionary = new Dictionary<string, string>
static readonly IReadOnlyDictionary<string, string> _testTokenDictionary = new Dictionary<string, string>
{
{ "UITestToken_brminnick", Environment.GetEnvironmentVariable("UITestToken_brminnick") ?? string.Empty },
{ "UITestToken_GitTrendsApp", Environment.GetEnvironmentVariable("UITestToken_GitTrendsApp") ?? string.Empty },
Expand Down
8 changes: 4 additions & 4 deletions GitTrends.Functions/Functions/SendSilentPushNotification.cs
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,11 @@ public class SendSilentPushNotification
{
const string _runTwicePerDay = "0 0 */12 * * *";

readonly static string _notificationHubFullConnectionString_Debug = Environment.GetEnvironmentVariable("NotificationHubFullConnectionString_Debug") ?? string.Empty;
readonly static string _notificationHubFullConnectionString = Environment.GetEnvironmentVariable("NotificationHubFullConnectionString") ?? string.Empty;
static readonly string _notificationHubFullConnectionString_Debug = Environment.GetEnvironmentVariable("NotificationHubFullConnectionString_Debug") ?? string.Empty;
static readonly string _notificationHubFullConnectionString = Environment.GetEnvironmentVariable("NotificationHubFullConnectionString") ?? string.Empty;

readonly static Lazy<NotificationHubClient> _clientHolder = new(NotificationHubClient.CreateClientFromConnectionString(_notificationHubFullConnectionString, GetNotificationHubInformation.NotificationHubName));
readonly static Lazy<NotificationHubClient> _debugClientHolder = new(NotificationHubClient.CreateClientFromConnectionString(_notificationHubFullConnectionString_Debug, GetNotificationHubInformation.NotificationHubName_Debug));
static readonly Lazy<NotificationHubClient> _clientHolder = new(NotificationHubClient.CreateClientFromConnectionString(_notificationHubFullConnectionString, GetNotificationHubInformation.NotificationHubName));
static readonly Lazy<NotificationHubClient> _debugClientHolder = new(NotificationHubClient.CreateClientFromConnectionString(_notificationHubFullConnectionString_Debug, GetNotificationHubInformation.NotificationHubName_Debug));

static NotificationHubClient Client => _clientHolder.Value;
static NotificationHubClient DebugClient => _debugClientHolder.Value;
Expand Down
4 changes: 2 additions & 2 deletions GitTrends.Functions/Program.cs
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ namespace GitTrends.Functions
{
class Program
{
readonly static string _token = Environment.GetEnvironmentVariable("UITestToken_brminnick") ?? string.Empty;
readonly static string _storageConnectionString = Environment.GetEnvironmentVariable("AzureWebJobsStorage") ?? string.Empty;
static readonly string _token = Environment.GetEnvironmentVariable("UITestToken_brminnick") ?? string.Empty;
static readonly string _storageConnectionString = Environment.GetEnvironmentVariable("AzureWebJobsStorage") ?? string.Empty;

static Task Main(string[] args)
{
Expand Down
2 changes: 1 addition & 1 deletion GitTrends.Functions/Services/NuGetService.cs
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ class NuGetService
{
readonly SourceRepository _sourceRepository = Repository.Factory.GetCoreV3("https://api.nuget.org/v3/index.json");

readonly static IReadOnlyList<string> _csProjFilePaths = new[]
static readonly IReadOnlyList<string> _csProjFilePaths = new[]
{
Environment.GetEnvironmentVariable("iOSCSProjPath") ?? string.Empty,
Environment.GetEnvironmentVariable("UITestCSProjPath") ?? string.Empty,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ namespace GitTrends.Mobile.Common
{
public abstract class AzureFunctionsApiService : BaseApiService
{
readonly static Lazy<IAzureFunctionsApi> _azureFunctionsApiClientHolder = new(() => RefitExtensions.For<IAzureFunctionsApi>(CreateHttpClient(AzureConstants.AzureFunctionsApiUrl)));
static readonly Lazy<IAzureFunctionsApi> _azureFunctionsApiClientHolder = new(() => RefitExtensions.For<IAzureFunctionsApi>(CreateHttpClient(AzureConstants.AzureFunctionsApiUrl)));

static IAzureFunctionsApi AzureFunctionsApiClient => _azureFunctionsApiClientHolder.Value;

Expand Down
4 changes: 2 additions & 2 deletions GitTrends.Mobile.Common/Services/EmptyDataViewService.cs
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,14 @@ namespace GitTrends.Mobile.Common
{
public static class EmptyDataViewService
{
readonly static IReadOnlyList<string> _zeroStarsEmptyDataViewDescription = new[]
static readonly IReadOnlyList<string> _zeroStarsEmptyDataViewDescription = new[]
{
EmptyDataViewConstantsInternal.ZeroStarsEmptyDataViewDescription1,
EmptyDataViewConstantsInternal.ZeroStarsEmptyDataViewDescription2,
EmptyDataViewConstantsInternal.ZeroStarsEmptyDataViewDescription3
};

readonly static Random _random = new((int)DateTime.Now.Ticks);
static readonly Random _random = new((int)DateTime.Now.Ticks);

public static string GetReferringSitesTitleText(in RefreshState refreshState) => refreshState switch
{
Expand Down
2 changes: 1 addition & 1 deletion GitTrends.UnitTests/MockServices/MockBrowser.cs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ namespace GitTrends.UnitTests
{
public class MockBrowser : IBrowser
{
readonly static WeakEventManager<Uri> _openAsyncExecutedEventHandler = new();
static readonly WeakEventManager<Uri> _openAsyncExecutedEventHandler = new();

public static event EventHandler<Uri> OpenAsyncExecuted
{
Expand Down
2 changes: 1 addition & 1 deletion GitTrends.UnitTests/MockServices/MockLauncher.cs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ namespace GitTrends.UnitTests
{
class MockLauncher : ILauncher
{
readonly static WeakEventManager _openAsyncExecutedEventHandler = new();
static readonly WeakEventManager _openAsyncExecutedEventHandler = new();

public static event EventHandler OpenAsyncExecuted
{
Expand Down
2 changes: 1 addition & 1 deletion GitTrends.UnitTests/MockServices/MockPreferences.cs
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ namespace GitTrends.UnitTests
{
public class MockPreferences : IPreferences
{
readonly static Lazy<Hashtable> _hashtableHolder = new();
static readonly Lazy<Hashtable> _hashtableHolder = new();

static Hashtable Hashtable => _hashtableHolder.Value;

Expand Down
2 changes: 1 addition & 1 deletion GitTrends.UnitTests/MockServices/MockSecureStorage.cs
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ namespace GitTrends.UnitTests
{
class MockSecureStorage : ISecureStorage
{
readonly static Lazy<Hashtable> _hashtableHolder = new();
static readonly Lazy<Hashtable> _hashtableHolder = new();

static Hashtable Hashtable => _hashtableHolder.Value;

Expand Down
6 changes: 3 additions & 3 deletions GitTrends.UnitTests/MockServices/MockStoreReview.cs
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@ namespace GitTrends.UnitTests
{
public class MockStoreReview : IStoreReview
{
readonly static WeakEventManager<bool> _reviewRequestedEventManager = new();
readonly static WeakEventManager<string> _storeListingOpenedEventManager = new();
readonly static WeakEventManager<string> _storeReviewPageOpenedEventManager = new();
static readonly WeakEventManager<bool> _reviewRequestedEventManager = new();
static readonly WeakEventManager<string> _storeListingOpenedEventManager = new();
static readonly WeakEventManager<string> _storeReviewPageOpenedEventManager = new();

public static event EventHandler<string> StoreListingOpened
{
Expand Down
2 changes: 1 addition & 1 deletion GitTrends/App.cs
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ namespace GitTrends
{
public class App : Xamarin.Forms.Application
{
readonly static WeakEventManager _resumedEventManager = new();
static readonly WeakEventManager _resumedEventManager = new();

readonly IAnalyticsService _analyticsService;
readonly NotificationService _notificationService;
Expand Down
2 changes: 1 addition & 1 deletion GitTrends/Services/AppInitializationService.cs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ namespace GitTrends
{
public class AppInitializationService
{
readonly static WeakEventManager<InitializationCompleteEventArgs> _initializationCompletedEventManager = new();
static readonly WeakEventManager<InitializationCompleteEventArgs> _initializationCompletedEventManager = new();

readonly ThemeService _themeService;
readonly LanguageService _languageService;
Expand Down
10 changes: 5 additions & 5 deletions GitTrends/Services/BackgroundFetchService.cs
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,11 @@ namespace GitTrends
{
public class BackgroundFetchService
{
readonly static WeakEventManager _eventManager = new();
readonly static WeakEventManager<bool> _scheduleNotifyTrendingRepositoriesCompletedEventManager = new();
readonly static WeakEventManager<string> _scheduleRetryOrganizationsRepositoriesCompletedEventManager = new();
readonly static WeakEventManager<Repository> _repostoryEventManager = new();
readonly static WeakEventManager<MobileReferringSiteModel> _mobileReferringSiteRetrievedEventManager = new();
static readonly WeakEventManager _eventManager = new();
static readonly WeakEventManager<bool> _scheduleNotifyTrendingRepositoriesCompletedEventManager = new();
static readonly WeakEventManager<string> _scheduleRetryOrganizationsRepositoriesCompletedEventManager = new();
static readonly WeakEventManager<Repository> _repostoryEventManager = new();
static readonly WeakEventManager<MobileReferringSiteModel> _mobileReferringSiteRetrievedEventManager = new();

readonly IJobManager _jobManager;
readonly IAnalyticsService _analyticsService;
Expand Down
2 changes: 1 addition & 1 deletion GitTrends/Services/ContainerService.cs
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ namespace GitTrends
{
public static class ContainerService
{
readonly static Lazy<IContainer> _containerHolder = new(CreateContainer);
static readonly Lazy<IContainer> _containerHolder = new(CreateContainer);

public static IContainer Container => _containerHolder.Value;

Expand Down
4 changes: 2 additions & 2 deletions GitTrends/Services/GitHubApiRepositoriesService.cs
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ namespace GitTrends
{
public class GitHubApiRepositoriesService
{
readonly static WeakEventManager<(Repository Repository, TimeSpan RetryTimeSpan)> _abuseRateLimitFoundEventManager = new();
readonly static WeakEventManager<Uri> _repositoryUriNotFoundEventManager = new();
static readonly WeakEventManager<(Repository Repository, TimeSpan RetryTimeSpan)> _abuseRateLimitFoundEventManager = new();
static readonly WeakEventManager<Uri> _repositoryUriNotFoundEventManager = new();

readonly FavIconService _favIconService;
readonly IAnalyticsService _analyticsService;
Expand Down
8 changes: 4 additions & 4 deletions GitTrends/Services/GitHubAuthenticationService.cs
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,10 @@ namespace GitTrends
{
public class GitHubAuthenticationService
{
readonly static WeakEventManager _loggedOuteventManager = new();
readonly static WeakEventManager _demoUserActivatedEventManager = new();
readonly static WeakEventManager _authorizeSessionStartedEventManager = new();
readonly static WeakEventManager<AuthorizeSessionCompletedEventArgs> _authorizeSessionCompletedEventManager = new();
static readonly WeakEventManager _loggedOuteventManager = new();
static readonly WeakEventManager _demoUserActivatedEventManager = new();
static readonly WeakEventManager _authorizeSessionStartedEventManager = new();
static readonly WeakEventManager<AuthorizeSessionCompletedEventArgs> _authorizeSessionCompletedEventManager = new();

readonly IPreferences _preferences;
readonly IAnalyticsService _analyticsService;
Expand Down
2 changes: 1 addition & 1 deletion GitTrends/Services/GitHubGraphQLApiService.cs
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ namespace GitTrends
{
public class GitHubGraphQLApiService : BaseMobileApiService
{
readonly static WeakEventManager<(string, TimeSpan)> _abuseRateLimitFound_GetOrganizationRepositoriesEventManager = new();
static readonly WeakEventManager<(string, TimeSpan)> _abuseRateLimitFound_GetOrganizationRepositoriesEventManager = new();

readonly IGitHubGraphQLApi _githubApiClient;
readonly GitHubUserService _gitHubUserService;
Expand Down
8 changes: 4 additions & 4 deletions GitTrends/Services/GitHubUserService.cs
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,10 @@ public class GitHubUserService
{
const string _oauthTokenKey = "OAuthToken";

readonly static WeakEventManager<string> _nameChangedEventManager = new();
readonly static WeakEventManager<string> _aliasChangedEventManager = new();
readonly static WeakEventManager<string> _avatarUrlChangedEventManager = new();
readonly static WeakEventManager<bool> _shouldIncludeOrganizationsChangedEventManager = new();
static readonly WeakEventManager<string> _nameChangedEventManager = new();
static readonly WeakEventManager<string> _aliasChangedEventManager = new();
static readonly WeakEventManager<string> _avatarUrlChangedEventManager = new();
static readonly WeakEventManager<bool> _shouldIncludeOrganizationsChangedEventManager = new();

readonly IPreferences _preferences;
readonly ISecureStorage _secureStorage;
Expand Down
2 changes: 1 addition & 1 deletion GitTrends/Services/LanguageService.cs
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ namespace GitTrends
{
public class LanguageService
{
readonly static WeakEventManager<string?> _preferredLanguageChangedEventManager = new();
static readonly WeakEventManager<string?> _preferredLanguageChangedEventManager = new();

readonly IMainThread _mainThread;
readonly IPreferences _preferences;
Expand Down
2 changes: 1 addition & 1 deletion GitTrends/Services/MediaElementService.cs
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ namespace GitTrends
{
public class MediaElementService
{
readonly static WeakEventManager<StreamingManifest?> _streamingManifestChangedEventManager = new();
static readonly WeakEventManager<StreamingManifest?> _streamingManifestChangedEventManager = new();

readonly IDeviceInfo _deviceInfo;
readonly IPreferences _preferences;
Expand Down
6 changes: 3 additions & 3 deletions GitTrends/Services/NotificationService.cs
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,9 @@ public class NotificationService
{
const string _getNotificationHubInformationKey = "GetNotificationHubInformation";

readonly static WeakEventManager<SortingOption> _sortingOptionRequestedEventManager = new();
readonly static WeakEventManager<NotificationHubInformation> _initializationCompletedEventManager = new();
readonly static WeakEventManager<(bool isSuccessful, string errorMessage)> _registerForNotificationCompletedEventHandler = new();
static readonly WeakEventManager<SortingOption> _sortingOptionRequestedEventManager = new();
static readonly WeakEventManager<NotificationHubInformation> _initializationCompletedEventManager = new();
static readonly WeakEventManager<(bool isSuccessful, string errorMessage)> _registerForNotificationCompletedEventHandler = new();

readonly IDeviceInfo _deviceInfo;
readonly IPreferences _preferences;
Expand Down
2 changes: 1 addition & 1 deletion GitTrends/Services/ReviewService.cs
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ public class ReviewService
public const int MinimumAppInstallDays = 14;
public const int MinimumMostRecentRequestDays = 90;

readonly static AsyncAwaitBestPractices.WeakEventManager _reviewPromptRequestedEventManager = new();
static readonly AsyncAwaitBestPractices.WeakEventManager _reviewPromptRequestedEventManager = new();

readonly IAppInfo _appInfo;
readonly IStoreReview _storeReview;
Expand Down
4 changes: 2 additions & 2 deletions GitTrends/Services/SyncfusionService.cs
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ namespace GitTrends
{
public class SyncfusionService
{
readonly static Lazy<long> _assemblyVersionNumberHolder = new(() => long.Parse(System.Reflection.Assembly.GetAssembly(typeof(Syncfusion.CoreAssembly)).GetName().Version.ToString().Replace(".", "")));
readonly static Lazy<string> _syncfusionLicenseKeyHolder = new(() => $"{nameof(SyncFusionDTO.LicenseKey)}{_assemblyVersionNumberHolder.Value}");
static readonly Lazy<long> _assemblyVersionNumberHolder = new(() => long.Parse(System.Reflection.Assembly.GetAssembly(typeof(Syncfusion.CoreAssembly)).GetName().Version.ToString().Replace(".", "")));
static readonly Lazy<string> _syncfusionLicenseKeyHolder = new(() => $"{nameof(SyncFusionDTO.LicenseKey)}{_assemblyVersionNumberHolder.Value}");

readonly ISecureStorage _secureStorage;
readonly IAnalyticsService _analyticsService;
Expand Down
2 changes: 1 addition & 1 deletion GitTrends/Services/ThemeService.cs
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ namespace GitTrends
{
public class ThemeService
{
readonly static WeakEventManager<PreferredTheme> _preferenceChangedEventManager = new();
static readonly WeakEventManager<PreferredTheme> _preferenceChangedEventManager = new();

readonly IMainThread _mainThread;
readonly IPreferences _preferences;
Expand Down
4 changes: 2 additions & 2 deletions GitTrends/Services/UITestsBackdoorService.cs
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ namespace GitTrends
{
public class UITestsBackdoorService
{
readonly static AsyncAwaitBestPractices.WeakEventManager _popPageStartedEventManager = new();
readonly static WeakEventManager<Page> _popPageCompletedEventManager = new();
static readonly AsyncAwaitBestPractices.WeakEventManager _popPageStartedEventManager = new();
static readonly WeakEventManager<Page> _popPageCompletedEventManager = new();

readonly IMainThread _mainThread;
readonly IStoreReview _storeReview;
Expand Down
2 changes: 1 addition & 1 deletion GitTrends/ViewModels/Base/GitHubAuthenticationViewModel.cs
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ protected virtual Task HandleDemoButtonTapped(string? buttonText)
}

[RelayCommand(CanExecute = nameof(IsNotAuthenticating))]
protected async virtual Task HandleConnectToGitHubButton((CancellationToken cancellationToken, Xamarin.Essentials.BrowserLaunchOptions? browserLaunchOptions) parameter)
protected virtual async Task HandleConnectToGitHubButton((CancellationToken cancellationToken, Xamarin.Essentials.BrowserLaunchOptions? browserLaunchOptions) parameter)
{
var (cancellationToken, browserLaunchOptions) = parameter;

Expand Down
2 changes: 1 addition & 1 deletion GitTrends/ViewModels/OnboardingViewModel.cs
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ namespace GitTrends
{
public partial class OnboardingViewModel : GitHubAuthenticationViewModel
{
readonly static WeakEventManager _skipButtonTappedEventManager = new();
static readonly WeakEventManager _skipButtonTappedEventManager = new();

readonly IAnalyticsService _analyticsService;
readonly NotificationService _notificationService;
Expand Down
Loading
Loading