Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Shiny.Notifications from 2.5.5 to 2.6.0 #506

Merged
merged 2 commits into from
Aug 12, 2022
Merged

Bump Shiny.Notifications from 2.5.5 to 2.6.0 #506

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a455f16
Bump Shiny.Notifications from 2.5.5 to 2.6.0
dependabot[bot] Aug 12, 2022
b537c05
Update Interface
TheCodeTraveler Aug 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion GitTrends.Android/GitTrends.Android.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@
<PackageReference Include="Autofac" Version="6.4.0" />
<PackageReference Include="Microsoft.AppCenter.Analytics" Version="4.5.3" />
<PackageReference Include="Microsoft.AppCenter.Crashes" Version="4.5.3" />
<PackageReference Include="Shiny.Notifications" Version="2.5.5" />
<PackageReference Include="Shiny.Notifications" Version="2.6.0" />
<PackageReference Include="Xam.Plugins.Android.ExoPlayer" Version="2.11.8" />
<PackageReference Include="Xamarin.Firebase.Messaging" Version="122.0.0.5" />
<PackageReference Include="Microsoft.Azure.NotificationHubs" Version="4.1.0" />
Expand Down
4 changes: 4 additions & 0 deletions GitTrends.UnitTests/MockServices/MockNotificationManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,10 @@ public Task ClearChannels()

public Task<IList<Channel>> GetChannels() => Task.FromResult((IList<Channel>)_channelsDictionary.Values.ToList());

public Task<Channel?> GetChannel(string channelId) => _channelsDictionary.TryGetValue(channelId, out var channel)
? Task.FromResult<Channel?>(channel)
: Task.FromResult<Channel?>(null);

public Task RemoveChannel(string channelId)
{
_channelsDictionary.Remove(channelId);
Expand Down
2 changes: 1 addition & 1 deletion GitTrends.iOS/CustomRenderers/SearchPageRenderer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ void HandleSizeChanged(object sender, EventArgs e)
{
Element.SizeChanged -= HandleSizeChanged;

if (NavigationController.NavigationBar.PrefersLargeTitles is true)
if (NavigationController?.NavigationBar.PrefersLargeTitles is true)
{
var statusBarSize = UIApplication.SharedApplication.StatusBarFrame.Size;
var statusBarHeight = Math.Min(statusBarSize.Height, statusBarSize.Width);
Expand Down
2 changes: 1 addition & 1 deletion GitTrends.iOS/GitTrends.iOS.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -477,7 +477,7 @@
<PackageReference Include="Xamarin.TestCloud.Agent" Version="0.23.1" />
<PackageReference Include="Microsoft.AppCenter.Analytics" Version="4.5.3" />
<PackageReference Include="Microsoft.AppCenter.Crashes" Version="4.5.3" />
<PackageReference Include="Shiny.Notifications" Version="2.5.5" />
<PackageReference Include="Shiny.Notifications" Version="2.6.0" />
<PackageReference Include="Microsoft.Azure.NotificationHubs" Version="4.1.0" />
<PackageReference Include="Xamarin.Forms.PancakeView" Version="2.3.0.763-beta" />
<PackageReference Include="Xamarin.Essentials.Interfaces" Version="1.7.3.2" />
Expand Down
2 changes: 1 addition & 1 deletion GitTrends/GitTrends.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
<PackageReference Include="Microsoft.AppCenter.Analytics" Version="4.5.3" />
<PackageReference Include="Microsoft.AppCenter.Crashes" Version="4.5.3" />
<PackageReference Include="Xamarin.Forms" Version="5.0.0.2515" />
<PackageReference Include="Shiny.Notifications" Version="2.5.5" />
<PackageReference Include="Shiny.Notifications" Version="2.6.0" />
<PackageReference Include="Xamarin.Forms.PancakeView" Version="2.3.0.763-beta" />
<PackageReference Include="Plugin.StoreReview" Version="3.3.1" />
<PackageReference Include="Sharpnado.MaterialFrame" Version="1.3.0" />
Expand Down